TBC Anniversary support

Author: NoM0Re

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -37,6 +37,7 @@ body:
       - Mists of Pandaria Classic
       - Cataclysm Classic
       - Titan Reforged
+      - Burning Crusade Anniversary
       - Classic Era
   validations:
     required: true

.luacheckrc

@@ -89,6 +89,7 @@ globals = {
 	"C_DateAndTime",
 	"C_EditMode",
 	"ChatFrame_AddMessageEventFilter",
+	"ChatFrameUtil",
 	"Clamp",
 	"COMBAT_TEXT_SCROLL_FUNCTION",
 	"CombatLogGetCurrentEventInfo",

WeakAuras/BuffTrigger2.lua

@@ -2385,7 +2385,7 @@ Buff2Frame:RegisterEvent("UNIT_PET")
 Buff2Frame:RegisterEvent("RAID_TARGET_UPDATE")
 Buff2Frame:RegisterEvent("PLAYER_SOFT_ENEMY_CHANGED")
 Buff2Frame:RegisterEvent("PLAYER_SOFT_FRIEND_CHANGED")
-if WeakAuras.IsWrathOrCataOrMistsOrRetail() then
+if WeakAuras.IsTBCOrWrathOrCataOrMistsOrRetail() then
   Buff2Frame:RegisterEvent("PLAYER_FOCUS_CHANGED")
   Buff2Frame:RegisterEvent("ARENA_OPPONENT_UPDATE")
   Buff2Frame:RegisterEvent("UNIT_ENTERED_VEHICLE")
@@ -3182,7 +3182,7 @@ function BuffTrigger.Add(data)
       local groupTrigger = trigger.unit == "group" or trigger.unit == "raid" or trigger.unit == "party"
       local effectiveIgnoreSelf = (groupTrigger or trigger.unit == "nameplate") and trigger.ignoreSelf
       local effectiveGroupRole = WeakAuras.IsWrathOrCataOrMistsOrRetail() and (groupTrigger and trigger.useGroupRole and trigger.group_role) or nil
-      local effectiveRaidRole = WeakAuras.IsClassicOrWrathOrCataOrMists() and (groupTrigger and trigger.useRaidRole and trigger.raid_role) or nil
+      local effectiveRaidRole = WeakAuras.IsClassicOrTBCOrWrathOrCataOrMists() and (groupTrigger and trigger.useRaidRole and trigger.raid_role) or nil
       local effectiveClass = groupTrigger and trigger.useClass and trigger.class
       local effectiveSpecId = WeakAuras.IsCataOrMistsOrRetail() and (groupTrigger and trigger.useActualSpec and trigger.actualSpec) or nil
       local effectiveArenaSpec = WeakAuras.IsRetail() and (trigger.unit == "arena" and trigger.useArenaSpec and trigger.arena_spec) or nil

WeakAuras/Compatibility.lua

@@ -76,13 +76,18 @@ else
 end
 
 if C_SpecializationInfo and C_SpecializationInfo.GetTalentInfo and not WeakAuras.IsClassicEra() then
-  if WeakAuras.IsWrathClassic() then
-    -- copy pasta from Interface/AddOns/Blizzard_DeprecatedSpecialization/Deprecated_Specialization_Wrath.lua
+  if WeakAuras.IsTBCOrWrathOrCata() then
+    -- copy pasta from
+    -- Interface/AddOns/Blizzard_DeprecatedSpecialization/
+    -- ├─ Deprecated_Specialization_TBC.lua
+    -- ├─ Deprecated_Specialization_Wrath.lua
+    -- └─ Deprecated_Specialization_Cata.lua
     Private.ExecEnv.GetTalentInfo = function(tabIndex, talentIndex, isInspect, isPet, groupIndex)
       local talentInfoQuery = {}
       talentInfoQuery.specializationIndex = tabIndex
       talentInfoQuery.talentIndex = talentIndex
       talentInfoQuery.isInspect = isInspect
+      talentInfoQuery.isPet = isPet
       talentInfoQuery.groupIndex = groupIndex
       local talentInfo = C_SpecializationInfo.GetTalentInfo(talentInfoQuery)
       if not talentInfo then

WeakAuras/GenericTrigger.lua

@@ -1998,7 +1998,7 @@ end
 do
   local mh = GetInventorySlotInfo("MainHandSlot")
   local oh = GetInventorySlotInfo("SecondaryHandSlot")
-  local ranged = WeakAuras.IsClassicOrWrath() and GetInventorySlotInfo("RangedSlot")
+  local ranged = WeakAuras.IsClassicOrTBCOrWrath() and GetInventorySlotInfo("RangedSlot")
 
   local swingTimerFrame;
   local lastSwingMain, lastSwingOff, lastSwingRange;
@@ -2193,7 +2193,7 @@ do
         end)
       end
       if Private.reset_ranged_swing_spells[spell] then
-        if WeakAuras.IsClassicOrWrath() then
+        if WeakAuras.IsClassicOrTBCOrWrath() then
           swingStart("ranged")
         else
           swingStart("main")
@@ -2226,7 +2226,7 @@ do
       swingTimerFrame:RegisterEvent("PLAYER_EQUIPMENT_CHANGED");
       swingTimerFrame:RegisterUnitEvent("UNIT_ATTACK_SPEED", "player");
       swingTimerFrame:RegisterUnitEvent("UNIT_SPELLCAST_SUCCEEDED", "player");
-      if WeakAuras.IsClassicOrWrath() then
+      if WeakAuras.IsClassicOrTBCOrWrath() then
         swingTimerFrame:RegisterUnitEvent("UNIT_SPELLCAST_START", "player")
         swingTimerFrame:RegisterUnitEvent("UNIT_SPELLCAST_INTERRUPTED", "player")
         swingTimerFrame:RegisterUnitEvent("UNIT_SPELLCAST_FAILED", "player")
@@ -2288,7 +2288,7 @@ do
   local function CheckGCD()
     local event;
     local startTime, duration, _, modRate
-    if WeakAuras.IsClassicOrWrath() then
+    if WeakAuras.IsClassicOrTBCOrWrath() then
       startTime, duration = GetSpellCooldown(29515);
       shootStart, shootDuration = GetSpellCooldown(5019)
     elseif GetSpellCooldown then
@@ -2407,7 +2407,7 @@ do
 
     if duration > 0 then
       if (startTime == gcdStart and duration == gcdDuration)
-          or (WeakAuras.IsClassicOrWrath() and duration == shootDuration and startTime == shootStart)
+          or (WeakAuras.IsClassicOrTBCOrWrath() and duration == shootDuration and startTime == shootStart)
       then
         -- GCD cooldown, this could mean that the spell reset!
         if self.expirationTime[id] and self.expirationTime[id] > endTime and self.expirationTime[id] ~= 0 then
@@ -3764,7 +3764,7 @@ function WeakAuras.WatchUnitChange(unit)
     end
 
     local roleUpdate
-    if WeakAuras.IsClassicOrWrath() then
+    if WeakAuras.IsClassicOrTBCOrWrath() then
       function roleUpdate(unit, eventsToSend)
         -- For classic check both raid role and group role
         local oldRaidRole = watchUnitChange.unitRaidRole[unit]
@@ -4039,7 +4039,7 @@ function Private.ExecEnv.CheckTotemSpellId(spellId, triggerSpellId, followoverri
 end
 
 -- Queueable Spells
-if WeakAuras.IsClassicOrWrath() then
+if WeakAuras.IsClassicOrTBCOrWrath() then
   local queueableSpells
   local classQueueableSpells = {
     ["WARRIOR"] = {
@@ -4098,7 +4098,7 @@ local GetSpellPowerCost = GetSpellPowerCost or C_Spell and C_Spell.GetSpellPower
 ---@return number? cost
 function WeakAuras.GetSpellCost(powerTypeToCheck)
   local spellID = select(9, WeakAuras.UnitCastingInfo("player"))
-  if WeakAuras.IsClassicOrWrath() and not spellID then
+  if WeakAuras.IsClassicOrTBCOrWrath() and not spellID then
     spellID = WeakAuras.GetQueuedSpell()
   end
   if spellID then
@@ -4116,7 +4116,7 @@ end
 
 -- Weapon Enchants
 do
-  local isCata = WeakAuras.IsCataClassic()
+  local hasRanged = WeakAuras.IsClassicOrTBCOrWrathOrCata()
 
   local mh = GetInventorySlotInfo("MainHandSlot")
   local oh = GetInventorySlotInfo("SecondaryHandSlot")
@@ -4131,7 +4131,7 @@ do
 
   local rw, rw_icon, rw_exp, rw_dur, rw_name, rw_shortenedName, rw_charges, rw_EnchantID;
   ---@type string?
-  if isCata then
+  if hasRanged then
     rw = GetInventorySlotInfo("RANGEDSLOT")
     rw_icon = GetInventoryItemTexture("player", rw) or "Interface\\Icons\\INV_Misc_QuestionMark"
   end
@@ -4149,7 +4149,7 @@ do
         tenchFrame:RegisterEvent("WEAPON_ENCHANT_CHANGED")
       end
       tenchFrame:RegisterUnitEvent("UNIT_INVENTORY_CHANGED", "player")
-      if WeakAuras.IsClassicOrWrath() then
+      if WeakAuras.IsClassicOrTBCOrWrath() then
         tenchFrame:RegisterEvent("PLAYER_EQUIPMENT_CHANGED");
       end
 
@@ -4182,11 +4182,11 @@ do
             if(v:GetObjectType() == "FontString") then
               local text = v:GetText();
               if(text) then
-                local _, _, name, shortenedName = text:find("^((.-) ?+?[VI%d]*) ?%(%d+%D+%)$");
+                local _, _, name, shortenedName = text:find("^((.-) ?+?[XVI%d]*) ?%(%d+%D+%)$");
                 if(name and name ~= "") then
                   return name, shortenedName;
                 end
-                _, _, name, shortenedName = text:find("^((.-) ?+?[VI%d]*)%（%d+.%D%）$");
+                _, _, name, shortenedName = text:find("^((.-) ?+?[XVI%d]*)%（%d+.%D%）$");
                 if(name and name ~= "") then
                   return name, shortenedName;
                 end
@@ -4226,7 +4226,7 @@ do
           end
           oh_icon = GetInventoryItemTexture("player", oh)
         end
-        if isCata then
+        if hasRanged then
           if(math.abs((rw_exp or 0) - (rw_exp_new or 0)) > 1) then
             rw_exp = rw_exp_new;
             rw_dur = rw_rem and rw_rem / 1000;

WeakAuras/Init.lua

@@ -429,6 +429,10 @@ end
 -- save compatibility with old auras
 WeakAuras.IsClassic = WeakAuras.IsClassicEra
 
+function WeakAuras.IsTBC()
+  return flavor == 2
+end
+
 ---@return boolean result
 function WeakAuras.IsWrathClassic()
   return flavor == 3
@@ -450,37 +454,53 @@ function WeakAuras.IsRetail()
 end
 
 ---@return boolean result
-function WeakAuras.IsClassicOrCata()
-  return WeakAuras.IsClassicEra() or WeakAuras.IsCataClassic()
+function WeakAuras.IsTWW()
+  return WeakAuras.BuildInfo >= 110000
 end
 
 ---@return boolean result
-function WeakAuras.IsClassicOrCataOrMists()
-  return WeakAuras.IsClassicOrCata() or WeakAuras.IsMists()
+function WeakAuras.IsMidnight()
+  return WeakAuras.BuildInfo >= 120000
 end
 
 ---@return boolean result
-function WeakAuras.IsCataOrMists()
-  return WeakAuras.IsCataClassic() or WeakAuras.IsMists()
+function WeakAuras.IsClassicOrTBC()
+  return WeakAuras.IsClassicEra() or WeakAuras.IsTBC()
 end
 
-function WeakAuras.IsCataOrMistsOrRetail()
-  return WeakAuras.IsCataClassic() or WeakAuras.IsMists() or WeakAuras.IsRetail()
+---@return boolean result
+function WeakAuras.IsClassicOrWrath()
+  return WeakAuras.IsClassicEra() or WeakAuras.IsWrathClassic()
 end
 
 ---@return boolean result
-function WeakAuras.IsMistsOrRetail()
-  return WeakAuras.IsMists() or WeakAuras.IsRetail()
+function WeakAuras.IsClassicOrTBCOrWrath()
+  return WeakAuras.IsClassicEra() or WeakAuras.IsTBC() or WeakAuras.IsWrathClassic()
 end
 
 ---@return boolean result
-function WeakAuras.IsCataOrRetail()
-  return WeakAuras.IsCataClassic() or WeakAuras.IsRetail()
+function WeakAuras.IsTBCOrWrath()
+  return WeakAuras.IsTBC() or WeakAuras.IsWrathClassic()
 end
 
 ---@return boolean result
-function WeakAuras.IsClassicOrWrath()
-  return WeakAuras.IsClassicEra() or WeakAuras.IsWrathClassic()
+function WeakAuras.IsClassicOrCata()
+  return WeakAuras.IsClassicEra() or WeakAuras.IsCataClassic()
+end
+
+---@return boolean result
+function WeakAuras.IsClassicOrTBCOrWrathOrCata()
+  return WeakAuras.IsClassicEra() or WeakAuras.IsTBC() or WeakAuras.IsWrathClassic() or WeakAuras.IsCataClassic()
+end
+
+---@return boolean result
+function WeakAuras.IsClassicOrTBCOrWrathOrCataOrMists()
+  return WeakAuras.IsClassicEra() or WeakAuras.IsTBC() or WeakAuras.IsWrathClassic() or WeakAuras.IsCataClassic() or WeakAuras.IsMists()
+end
+
+---@return boolean result
+function WeakAuras.IsTBCOrWrathOrCata()
+  return WeakAuras.IsTBC() or WeakAuras.IsWrathClassic() or WeakAuras.IsCataClassic()
 end
 
 ---@return boolean result
@@ -499,13 +519,23 @@ function WeakAuras.IsWrathOrCataOrMistsOrRetail()
 end
 
 ---@return boolean result
-function WeakAuras.IsClassicOrWrathOrCata()
-  return WeakAuras.IsClassicEra() or WeakAuras.IsWrathClassic() or WeakAuras.IsCataClassic()
+function WeakAuras.IsTBCOrWrathOrCataOrMists()
+  return WeakAuras.IsTBC() or WeakAuras.IsWrathClassic() or WeakAuras.IsCataClassic() or WeakAuras.IsMists()
+end
+
+---@return boolean result
+function WeakAuras.IsWrathOrMists()
+  return WeakAuras.IsWrathClassic() or WeakAuras.IsMists()
 end
 
 ---@return boolean result
-function WeakAuras.IsClassicOrWrathOrCataOrMists()
-  return WeakAuras.IsClassicEra() or WeakAuras.IsWrathClassic() or WeakAuras.IsCataClassic() or WeakAuras.IsMists()
+function WeakAuras.IsTBCOrWrathOrMists()
+  return WeakAuras.IsTBC() or WeakAuras.IsWrathClassic() or WeakAuras.IsMists()
+end
+
+---@return boolean result
+function WeakAuras.IsMistsOrRetail()
+  return WeakAuras.IsMists() or WeakAuras.IsRetail()
 end
 
 ---@return boolean result
@@ -514,22 +544,28 @@ function WeakAuras.IsWrathOrMistsOrRetail()
 end
 
 ---@return boolean result
-function WeakAuras.IsWrathOrMists()
-  return WeakAuras.IsWrathClassic() or WeakAuras.IsMists()
+function WeakAuras.IsTBCOrWrathOrMistsOrRetail()
+  return WeakAuras.IsTBC() or WeakAuras.IsWrathClassic() or WeakAuras.IsMists() or WeakAuras.IsRetail()
 end
 
 ---@return boolean result
-function WeakAuras.IsWrathOrRetail()
-  return WeakAuras.IsWrathClassic() or WeakAuras.IsRetail()
+function WeakAuras.IsCataOrMists()
+  return WeakAuras.IsCataClassic() or WeakAuras.IsMists()
 end
 
 ---@return boolean result
-function WeakAuras.IsTWW()
-  return WeakAuras.BuildInfo >= 110000
+function WeakAuras.IsCataOrMistsOrRetail()
+  return WeakAuras.IsCataClassic() or WeakAuras.IsMists() or WeakAuras.IsRetail()
 end
 
-function WeakAuras.IsMidnight()
-  return WeakAuras.BuildInfo >= 120000
+---@return boolean result
+function WeakAuras.IsTBCOrWrathOrCataOrMistsOrRetail()
+  return WeakAuras.IsTBC() or WeakAuras.IsWrathClassic() or WeakAuras.IsCataClassic() or WeakAuras.IsMists() or WeakAuras.IsRetail()
+end
+
+---@return boolean result
+function WeakAuras.IsWrathOrRetail()
+  return WeakAuras.IsWrathClassic() or WeakAuras.IsRetail()
 end
 
 ---@param ... string

WeakAuras/Modernize.lua

@@ -2015,7 +2015,7 @@ function Private.Modernize(data, oldSnapshot)
   end
 
   if data.internalVersion < 72 then
-    if WeakAuras.IsClassic() then
+    if WeakAuras.IsClassicEra() then
       if data.model_path and data.modelIsUnit then
         data.model_fileId = data.model_path
       end
@@ -2468,7 +2468,7 @@ function Private.Modernize(data, oldSnapshot)
   end
 
   if data.internalVersion < 88 then
-    if WeakAuras.IsWrathClassic() then
+    if WeakAuras.IsTBCOrWrath() then
       for _, triggerData in ipairs(data.triggers) do
         local trigger = triggerData.trigger
         if trigger and trigger.event == "Talent Known" and trigger.talent then