IsPlayerSpell and IsSpellKnown now make error an with 0

fixes #5328

Author: mrbuds

WeakAuras/Prototypes.lua

@@ -1045,11 +1045,12 @@ function Private.ExecEnv.CheckRaidFlags(flags, flagToCheck)
 end
 
 local function IsSpellKnownOrOverridesAndBaseIsKnown(spell, pet)
+  if spell == 0 then return false end
   if IsSpellKnown(spell, pet) then
     return true
   end
   local baseSpell = FindBaseSpellByID(spell)
-  if baseSpell and baseSpell ~= spell then
+  if baseSpell and baseSpell ~= spell and baseSpell ~= 0 then
     if FindSpellOverrideByID(baseSpell) == spell then
       return IsSpellKnown(baseSpell, pet)
     end
@@ -1059,11 +1060,12 @@ end
 ---@param spell string|number
 ---@return boolean result
 function WeakAuras.IsPlayerSpellOrOverridesAndBaseIsPlayerSpell(spell)
+  if spell == 0 then return false end
   if IsPlayerSpell(spell) then
     return true
   end
   local baseSpell = FindBaseSpellByID(spell)
-  if baseSpell and baseSpell ~= spell then
+  if baseSpell and baseSpell ~= spell and baseSpell ~= 0 then
     if FindSpellOverrideByID(baseSpell) == spell then
       return IsPlayerSpell(baseSpell)
     end
@@ -1073,6 +1075,7 @@ end
 
 ---@private
 function WeakAuras.IsSpellKnownForLoad(spell, exact)
+  if spell == 0 then return false end
   local result = IsPlayerSpell(spell)
                  or IsSpellKnownOrOverridesAndBaseIsKnown(spell, false)
                  or IsSpellKnownOrOverridesAndBaseIsKnown(spell, true)
@@ -1093,6 +1096,7 @@ end
 ---@param pet boolean?
 ---@return boolean result
 function WeakAuras.IsSpellKnown(spell, pet)
+  if spell == 0 then return false end
   if (pet) then
     return IsSpellKnownOrOverridesAndBaseIsKnown(spell, true)
   end

WeakAurasOptions/Cache.lua

@@ -142,7 +142,7 @@ function spellCache.GetIcon(name)
         for spell, icon in icons.spells:gmatch("(%d+)=(%d+)") do
           local spellId = tonumber(spell)
 
-          if not bestMatch or (spellId and IsSpellKnown(spellId)) then
+          if not bestMatch or (spellId and spellId ~= 0 and IsSpellKnown(spellId)) then
             bestMatch = tonumber(icon)
           end
         end