Skip to content

Commit 6ca0bfa

Browse files
committed
update tests
1 parent 9ce0d05 commit 6ca0bfa

File tree

4 files changed

+9
-37
lines changed

4 files changed

+9
-37
lines changed

test/wasm2js/atomics_32.2asm.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,7 @@ memorySegments[1] = base64DecodeToExistingUint8Array(new Uint8Array(6), 0, "d29y
8686
}
8787

8888
function wasm2js_memory_init(segment, dest, offset, size) {
89-
dest = dest >>> 0;
90-
offset = offset >>> 0;
91-
size = size >>> 0;
92-
// if (dest + size > bufferView.length) throw "trap: invalid memory.init";
93-
// if (offset + size > memorySegments[segment].length) throw "trap: invalid memory.init";
89+
// TODO: traps on invalid things
9490
bufferView.set(memorySegments[segment].subarray(offset, offset + size), dest);
9591
}
9692

test/wasm2js/atomics_32.2asm.js.opt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,7 @@ memorySegments[1] = base64DecodeToExistingUint8Array(new Uint8Array(6), 0, "d29y
8686
}
8787

8888
function wasm2js_memory_init(segment, dest, offset, size) {
89-
dest = dest >>> 0;
90-
offset = offset >>> 0;
91-
size = size >>> 0;
92-
// if (dest + size > bufferView.length) throw "trap: invalid memory.init";
93-
// if (offset + size > memorySegments[segment].length) throw "trap: invalid memory.init";
89+
// TODO: traps on invalid things
9490
bufferView.set(memorySegments[segment].subarray(offset, offset + size), dest);
9591
}
9692

test/wasm2js/bulk-memory.2asm.js

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ var retasmFunc = asmFunc({
2323
function wasm2js_memory_fill(dest, value, size) {
2424
dest = dest >>> 0;
2525
size = size >>> 0;
26-
// if (dest + size > bufferView.length) throw "trap: invalid memory.fill";
26+
if (dest + size > bufferView.length) throw "trap: invalid memory.fill";
2727
bufferView.fill(value, dest, dest + size);
2828
}
2929

@@ -123,11 +123,7 @@ function initActiveSegments(imports) {
123123
}
124124

125125
function wasm2js_memory_copy(dest, source, size) {
126-
dest = dest >>> 0;
127-
source = source >>> 0;
128-
size = size >>> 0;
129-
// if (dest + size > bufferView.length) throw "trap: invalid memory.copy";
130-
// if (source + size > bufferView.length) throw "trap: invalid memory.copy";
126+
// TODO: traps on invalid things
131127
bufferView.copyWithin(dest, source, source + size);
132128
}
133129

@@ -205,11 +201,7 @@ export var load8_u = retasmFunc.load8_u;
205201
memorySegments[0] = base64DecodeToExistingUint8Array(new Uint8Array(4), 0, "qrvM3Q==");
206202

207203
function wasm2js_memory_init(segment, dest, offset, size) {
208-
dest = dest >>> 0;
209-
offset = offset >>> 0;
210-
size = size >>> 0;
211-
// if (dest + size > bufferView.length) throw "trap: invalid memory.init";
212-
// if (offset + size > memorySegments[segment].length) throw "trap: invalid memory.init";
204+
// TODO: traps on invalid things
213205
bufferView.set(memorySegments[segment].subarray(offset, offset + size), dest);
214206
}
215207

@@ -316,11 +308,7 @@ function initActiveSegments(imports) {
316308
}
317309

318310
function wasm2js_memory_init(segment, dest, offset, size) {
319-
dest = dest >>> 0;
320-
offset = offset >>> 0;
321-
size = size >>> 0;
322-
// if (dest + size > bufferView.length) throw "trap: invalid memory.init";
323-
// if (offset + size > memorySegments[segment].length) throw "trap: invalid memory.init";
311+
// TODO: traps on invalid things
324312
bufferView.set(memorySegments[segment].subarray(offset, offset + size), dest);
325313
}
326314

test/wasm2js/bulk-memory.2asm.js.opt

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ var retasmFunc = asmFunc({
2323
function wasm2js_memory_fill(dest, value, size) {
2424
dest = dest >>> 0;
2525
size = size >>> 0;
26-
// if (dest + size > bufferView.length) throw "trap: invalid memory.fill";
26+
if (dest + size > bufferView.length) throw "trap: invalid memory.fill";
2727
bufferView.fill(value, dest, dest + size);
2828
}
2929

@@ -123,11 +123,7 @@ function initActiveSegments(imports) {
123123
}
124124

125125
function wasm2js_memory_copy(dest, source, size) {
126-
dest = dest >>> 0;
127-
source = source >>> 0;
128-
size = size >>> 0;
129-
// if (dest + size > bufferView.length) throw "trap: invalid memory.copy";
130-
// if (source + size > bufferView.length) throw "trap: invalid memory.copy";
126+
// TODO: traps on invalid things
131127
bufferView.copyWithin(dest, source, source + size);
132128
}
133129

@@ -205,11 +201,7 @@ export var load8_u = retasmFunc.load8_u;
205201
memorySegments[0] = base64DecodeToExistingUint8Array(new Uint8Array(4), 0, "qrvM3Q==");
206202

207203
function wasm2js_memory_init(segment, dest, offset, size) {
208-
dest = dest >>> 0;
209-
offset = offset >>> 0;
210-
size = size >>> 0;
211-
// if (dest + size > bufferView.length) throw "trap: invalid memory.init";
212-
// if (offset + size > memorySegments[segment].length) throw "trap: invalid memory.init";
204+
// TODO: traps on invalid things
213205
bufferView.set(memorySegments[segment].subarray(offset, offset + size), dest);
214206
}
215207

0 commit comments

Comments
 (0)