[C API]: Add BinaryenFunctionAddVar

Author: mobsceneZ

src/binaryen-c.cpp

@@ -5878,13 +5878,9 @@ BinaryenType BinaryenFunctionGetVar(BinaryenFunctionRef func,
   assert(index < vars.size());
   return vars[index].getID();
 }
-BinaryenIndex BinaryenFunctionAppendVar(BinaryenFunctionRef func,
-                                        BinaryenType type) {
-  auto* function = (Function*)func;
-  auto& list = function->vars;
-  auto index = list.size();
-  list.push_back((Type)type);
-  return index;
+BinaryenIndex BinaryenFunctionAddVar(BinaryenFunctionRef func,
+                                     BinaryenType type) {
+  return Builder::addVar((Function*)func, (Type)type);
 }
 BinaryenIndex BinaryenFunctionGetNumLocals(BinaryenFunctionRef func) {
   return ((Function*)func)->getNumLocals();

src/binaryen-c.h

@@ -3198,9 +3198,9 @@ BINARYEN_API BinaryenIndex BinaryenFunctionGetNumVars(BinaryenFunctionRef func);
 BINARYEN_API BinaryenType BinaryenFunctionGetVar(BinaryenFunctionRef func,
                                                  BinaryenIndex index);
 // Appends a local variable to the specified `Function`, returning its
-// insertion index.
-BINARYEN_API BinaryenIndex BinaryenFunctionAppendVar(BinaryenFunctionRef func,
-                                                     BinaryenType type);
+// index.
+BINARYEN_API BinaryenIndex BinaryenFunctionAddVar(BinaryenFunctionRef func,
+                                                  BinaryenType type);
 // Gets the number of locals within the specified function. Includes parameters.
 BINARYEN_API BinaryenIndex
 BinaryenFunctionGetNumLocals(BinaryenFunctionRef func);

test/example/c-api-kitchen-sink.c

@@ -1417,6 +1417,16 @@ void test_core() {
   BinaryenFunctionRef sinker = BinaryenAddFunction(
     module, "kitchen()sinker", iIfF, BinaryenTypeInt32(), localTypes, 2, body);
 
+  BinaryenIndex numLocals = BinaryenFunctionGetNumLocals(sinker);
+  BinaryenIndex numParams =
+    BinaryenTypeArity(BinaryenFunctionGetParams(sinker));
+  BinaryenIndex newLocalIdx =
+    BinaryenFunctionAddVar(sinker, BinaryenTypeFloat32());
+  assert(newLocalIdx == numLocals);
+  assert(BinaryenFunctionGetNumLocals(sinker) == numLocals + 1);
+  assert(BinaryenFunctionGetVar(sinker, newLocalIdx - numParams) ==
+         BinaryenTypeFloat32());
+
   // Globals
 
   BinaryenAddGlobal(

test/example/c-api-kitchen-sink.txt

@@ -102,6 +102,7 @@ BinaryenFeatureAll: 131071
  (func $"kitchen()sinker" (type $2) (param $0 i32) (param $1 i64) (param $2 f32) (param $3 f64) (result i32)
   (local $4 i32)
   (local $5 externref)
+  (local $6 f32)
   (block $the-body (result i32)
    (block $the-nothing
     (drop