Skip to content

Support BINARYEN_TRAP_MODEs for upstream wasm backend #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dschuff opened this issue Aug 22, 2017 · 1 comment
Closed

Support BINARYEN_TRAP_MODEs for upstream wasm backend #1143

dschuff opened this issue Aug 22, 2017 · 1 comment

Comments

@dschuff
Copy link
Member

dschuff commented Aug 22, 2017

Currently the implementation of clamping and JS mode for trapping float->int conversions and division is in asm2wasm. But it we should support this functionality with the wasm backend as well. Probably we can just move the implementation from asm2wasm into a Binaryen pass, and support it in s2wasm as well.
@dschuff dschuff changed the title Support BINARYEN_TRAP_MODEs for upstream wasm backend Support BINARYEN_TRAP_MODEs for upstream wasm backend Aug 22, 2017
@dschuff dschuff mentioned this issue Aug 22, 2017
Closed
@jgravelle-google
Copy link
Contributor

Supported in #1168 and #1210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dschuff @jgravelle-google