fix: restore active stacks with start_stack

Author: zhaojing1987

apphub/src/services/back_manager.py

@@ -426,10 +426,7 @@ def restore_backup(self, app_id: str, snapshot_id: str) -> None:
                             raise CustomException(404, "Not Found", f"Stack {app_id} has no Id")
                         portainer.up_stack(stack_id, endpoint_id)
                     else:
-                        stack_id = stack_info.get("Id")
-                        if stack_id is None:
-                            raise CustomException(404, "Not Found", f"Stack {app_id} has no Id")
-                        portainer.up_stack(stack_id, endpoint_id)
+                        portainer.start_stack(app_id, endpoint_id)
 
                     self._ensure_restored_app_running(portainer, app_id, endpoint_id)
                     logger.access(f"Started containers for app {app_id} after restore")

apphub/tests/test_backup_restore.py

@@ -42,13 +42,17 @@ def __init__(self, stack_status, container_sequences):
         self.stack_status = stack_status
         self.container_sequences = list(container_sequences)
         self.up_calls = []
+        self.start_calls = []
 
     def get_stack_by_name(self, app_id, endpoint_id):
         return {"Id": 9, "Name": app_id, "Status": self.stack_status}
 
     def up_stack(self, stack_id, endpoint_id):
         self.up_calls.append((stack_id, endpoint_id))
 
+    def start_stack(self, app_id, endpoint_id):
+        self.start_calls.append((app_id, endpoint_id))
+
     def get_containers_by_stack_name(self, app_id, endpoint_id):
         if self.container_sequences:
             return self.container_sequences.pop(0)
@@ -79,6 +83,35 @@ def test_restore_validation_uses_up_stack_for_inactive_stack(monkeypatch):
         portainer.up_stack(stack_info['Id'], 1)
 
     assert portainer.up_calls == [(9, 1)]
+    assert portainer.start_calls == []
+
+
+def test_restore_start_uses_start_stack_for_active_stack(monkeypatch):
+    manager = _build_manager()
+    portainer = FakePortainer(
+        stack_status=1,
+        container_sequences=[[
+            {"Names": ["/wordpress_demo"], "State": "running"},
+        ]],
+    )
+
+    monkeypatch.setattr(manager, '_check_repository', lambda: True)
+    monkeypatch.setattr(manager, 'list_snapshots', lambda app_id: [{"id": "snap-1", "short_id": "snap-1"}])
+    monkeypatch.setattr(manager, '_run_restic_container', lambda command, extra_volumes: '{"message_type":"summary"}')
+    monkeypatch.setattr(manager, '_ensure_restored_app_running', lambda *args, **kwargs: None)
+    monkeypatch.setattr(back_manager_module, 'AppManger', lambda: types.SimpleNamespace(
+        get_app_by_id=lambda app_id: types.SimpleNamespace(
+            endpointId=1,
+            volumes=[{"Mountpoint": "/var/lib/docker/volumes/wordpress_demo/_data", "Name": "wordpress_demo"}],
+        )
+    ))
+    monkeypatch.setattr(back_manager_module, 'PortainerManager', lambda: portainer)
+    monkeypatch.setattr(manager, '_resolve_host_path', lambda path: path)
+
+    manager.restore_backup('wordpress_demo', 'snap-1')
+
+    assert portainer.start_calls == [('wordpress_demo', 1)]
+    assert portainer.up_calls == []
 
 
 def test_restore_validation_rejects_only_exited_runtime_containers(monkeypatch):