Clean-up old error messages

Summary:
Use new error message generation for callback type errors, add corresponding test

Cleanup old error message generation

Reviewed By: TD5

Differential Revision: D88941623

fbshipit-source-id: 262c2031c7d19ad2528ef63a5d73d146fd84d408

Author: VLanvin

crates/elp/src/resources/test/eqwalizer_tests/check/callbacks3_neg-OTP-26.pretty

@@ -1,14 +1,27 @@
 error: incorrect_return_type_in_cb_implementation (See https://fb.me/eqwalizer_errors#incorrect_return_type_in_cb_implementation)
-   ┌─ check/src/callbacks3_neg.erl:12:1
+   ┌─ check/src/callbacks3_neg.erl:13:1
    │
-12 │ -behavior(gen_server).
+13 │ -behavior(gen_server).
+   │ ^^^^^^^^^^^^^^^^^^^^^ Incorrect return type for implementation of gen_server:handle_cast/2.
+Expected: {'noreply', term()} | {'noreply', term(), timeout() | 'hibernate' | {'continue', term()}} | {'stop', term(), term()}
+Got:      'wrong_ret'
+
+error: incorrect_return_type_in_cb_implementation (See https://fb.me/eqwalizer_errors#incorrect_return_type_in_cb_implementation)
+   ┌─ check/src/callbacks3_neg.erl:13:1
+   │
+13 │ -behavior(gen_server).
    │ ^^^^^^^^^^^^^^^^^^^^^
    │ │
-   │ Incorrect return type for implementation of gen_server:handle_cast/2. Expected: {'noreply', term()} | {'noreply', term(), timeout() | 'hibernate' | {'continue', term()}} | {'stop', term(), term()}, Got: 'wrong_ret'.
+   │ Incorrect return type for implementation of gen_server:handle_info/2.
+Expected: {'noreply', term()} | {'noreply', term(), timeout() | 'hibernate' | {'continue', term()}} | {'stop', term(), term()}
+Got:      {'noreply', 'ok', 'wrong_atom'}
    │ 
 
-  'wrong_ret' is not compatible with {'noreply', term()} | {'noreply', term(), timeout() | 'hibernate' | {'continue', term()}} | {'stop', term(), term()}
-  because
-  'wrong_ret' is not compatible with {'noreply', term()}
+Because in the expression's type:
+  { 'noreply', 'ok', 
+    Here the type is:     'wrong_atom'
+    Context expects type: 'infinity' | number() | 'hibernate' | {'continue', term()}
+    No candidate matches in the expected union.
+  }
 
-1 ERROR
+2 ERRORS

crates/elp/src/resources/test/eqwalizer_tests/check/callbacks3_neg-OTP-27.pretty

@@ -1,14 +1,27 @@
 error: incorrect_return_type_in_cb_implementation (See https://fb.me/eqwalizer_errors#incorrect_return_type_in_cb_implementation)
-   ┌─ check/src/callbacks3_neg.erl:12:1
+   ┌─ check/src/callbacks3_neg.erl:13:1
    │
-12 │ -behavior(gen_server).
+13 │ -behavior(gen_server).
+   │ ^^^^^^^^^^^^^^^^^^^^^ Incorrect return type for implementation of gen_server:handle_cast/2.
+Expected: {'noreply', term()} | {'noreply', term(), timeout() | 'hibernate' | {'continue', term()}} | {'stop', term(), term()}
+Got:      'wrong_ret'
+
+error: incorrect_return_type_in_cb_implementation (See https://fb.me/eqwalizer_errors#incorrect_return_type_in_cb_implementation)
+   ┌─ check/src/callbacks3_neg.erl:13:1
+   │
+13 │ -behavior(gen_server).
    │ ^^^^^^^^^^^^^^^^^^^^^
    │ │
-   │ Incorrect return type for implementation of gen_server:handle_cast/2. Expected: {'noreply', term()} | {'noreply', term(), timeout() | 'hibernate' | {'continue', term()}} | {'stop', term(), term()}, Got: 'wrong_ret'.
+   │ Incorrect return type for implementation of gen_server:handle_info/2.
+Expected: {'noreply', term()} | {'noreply', term(), timeout() | 'hibernate' | {'continue', term()}} | {'stop', term(), term()}
+Got:      {'noreply', 'ok', 'wrong_atom'}
    │ 
 
-  'wrong_ret' is not compatible with {'noreply', term()} | {'noreply', term(), timeout() | 'hibernate' | {'continue', term()}} | {'stop', term(), term()}
-  because
-  'wrong_ret' is not compatible with {'noreply', term()}
+Because in the expression's type:
+  { 'noreply', 'ok', 
+    Here the type is:     'wrong_atom'
+    Context expects type: 'infinity' | number() | 'hibernate' | {'continue', term()}
+    No candidate matches in the expected union.
+  }
 
-1 ERROR
+2 ERRORS

crates/elp/src/resources/test/eqwalizer_tests/check/callbacks3_neg-OTP-28.pretty

@@ -1,14 +1,26 @@
 error: incorrect_return_type_in_cb_implementation (See https://fb.me/eqwalizer_errors#incorrect_return_type_in_cb_implementation)
-   ┌─ check/src/callbacks3_neg.erl:12:1
+   ┌─ check/src/callbacks3_neg.erl:13:1
    │
-12 │ -behavior(gen_server).
+13 │ -behavior(gen_server).
+   │ ^^^^^^^^^^^^^^^^^^^^^ Incorrect return type for implementation of gen_server:handle_cast/2.
+Expected: {'noreply', term()} | {'noreply', term(), gen_server:action()} | {'stop', term(), term()}
+Got:      'wrong_ret'
+
+error: incorrect_return_type_in_cb_implementation (See https://fb.me/eqwalizer_errors#incorrect_return_type_in_cb_implementation)
+   ┌─ check/src/callbacks3_neg.erl:13:1
+   │
+13 │ -behavior(gen_server).
    │ ^^^^^^^^^^^^^^^^^^^^^
    │ │
-   │ Incorrect return type for implementation of gen_server:handle_cast/2. Expected: {'noreply', term()} | {'noreply', term(), gen_server:action()} | {'stop', term(), term()}, Got: 'wrong_ret'.
+   │ Incorrect return type for implementation of gen_server:handle_info/2.
+Expected: {'noreply', term()} | {'noreply', term(), gen_server:action()} | {'stop', term(), term()}
+Got:      {'noreply', 'ok', 'wrong_atom'}
    │ 
 
-  'wrong_ret' is not compatible with {'noreply', term()} | {'noreply', term(), gen_server:action()} | {'stop', term(), term()}
-  because
-  'wrong_ret' is not compatible with {'noreply', term()}
+Because in the expression's type:
+  { 'noreply', 'ok', 
+    Here the type is:     'wrong_atom'
+    Context expects type: gen_server:action()
+  }
 
-1 ERROR
+2 ERRORS

test_projects/eqwalizer_tests/check/src/callbacks3_neg.erl

@@ -7,7 +7,8 @@
 -export([
     init/1,
     handle_call/3,
-    handle_cast/2
+    handle_cast/2,
+    handle_info/2
 ]).
 -behavior(gen_server).
 
@@ -19,3 +20,7 @@ handle_call(_, _From, State) ->
 -spec handle_cast(ok, ok) -> wrong_ret.
 handle_cast(_, _) ->
     wrong_ret.
+
+-spec handle_info(ok, ok) -> {noreply, ok, wrong_atom}.
+handle_info(_, _) ->
+    {noreply, ok, wrong_atom}.