Skip to content

Commit c9a5b82

Browse files
committed
Refactor SurveyResultsController to inherit from SurveysController and use surveys layout
1 parent 845ea7c commit c9a5b82

2 files changed

Lines changed: 4 additions & 48 deletions

File tree

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
# frozen_string_literal: true
22

3-
class SurveyResultsController < ApplicationController
4-
before_action :require_admin_permissions
3+
class SurveyResultsController < SurveysController
4+
layout 'surveys'
5+
56
before_action :set_survey
6-
before_action :ensure_logged_in
77
before_action :set_question_groups
88

99
def results
@@ -19,27 +19,8 @@ def results
1919

2020
private
2121

22-
def set_survey
23-
@survey = Survey.find(params[:id])
24-
end
25-
2622
def set_question_groups
27-
@question_groups = Rapidfire::QuestionGroup.all
28-
@surveys_question_groups = SurveysQuestionGroup.by_position(params[:id])
23+
super
2924
@survey_user_cache = {}
3025
end
31-
32-
def ensure_logged_in
33-
return if params.include?('preview') # allow preview even by logged out users
34-
return true if current_user
35-
render 'login'
36-
end
37-
38-
# Prevents access to survey results if they are set to be confidential
39-
def protect_confidentiality
40-
return unless @survey.confidential_results
41-
render plain: 'The results for this survey are confidential.',
42-
status: :forbidden
43-
yield
44-
end
4526
end

app/views/layouts/survey_results.html.haml

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)