[Personal-WP] Fix ?plugin= URL parameter not installing plugins (#3218)

Author: akirk

packages/playground/personal-wp/src/lib/personalwp/index.spec.ts

@@ -0,0 +1,86 @@
+import { describe, it, expect, vi } from 'vitest';
+
+// Set up browser globals before any imports that might need them
+// @ts-ignore - minimal mock for testing
+global.location = {
+	origin: 'https://playground.wordpress.net',
+	href: 'https://playground.wordpress.net/',
+};
+// @ts-ignore - minimal mock for testing
+global.window = global.window || {};
+// @ts-ignore
+global.window.self = global.window;
+// @ts-ignore
+global.window.top = global.window;
+
+// Mock fetch for potential network requests
+global.fetch = vi.fn();
+
+// Now we can import the module
+const { resolveUrlParamsForExistingSite } = await import('./index');
+
+describe('resolveUrlParamsForExistingSite', () => {
+	it('returns null when no actionable URL params are present', async () => {
+		const url = new URL('https://playground.wordpress.net/');
+		const result = await resolveUrlParamsForExistingSite(url);
+		expect(result).toBeNull();
+	});
+
+	it('returns null for non-actionable params like ?mode=', async () => {
+		const url = new URL('https://playground.wordpress.net/?mode=seamless');
+		const result = await resolveUrlParamsForExistingSite(url);
+		expect(result).toBeNull();
+	});
+
+	it('returns blueprint with plugins property for ?plugin= param', async () => {
+		const url = new URL(
+			'https://playground.wordpress.net/?plugin=woocommerce'
+		);
+		const result = await resolveUrlParamsForExistingSite(url);
+
+		expect(result).not.toBeNull();
+		expect(result?.plugins).toEqual(['woocommerce']);
+	});
+
+	it('returns blueprint with multiple plugins for multiple ?plugin= params', async () => {
+		const url = new URL(
+			'https://playground.wordpress.net/?plugin=woocommerce&plugin=jetpack'
+		);
+		const result = await resolveUrlParamsForExistingSite(url);
+
+		expect(result).not.toBeNull();
+		expect(result?.plugins).toEqual(['woocommerce', 'jetpack']);
+	});
+
+	it('returns blueprint with installTheme steps for ?theme= param', async () => {
+		const url = new URL('https://playground.wordpress.net/?theme=flavor');
+		const result = await resolveUrlParamsForExistingSite(url);
+
+		expect(result).not.toBeNull();
+		expect(result?.steps).toBeDefined();
+
+		const themeStep = result?.steps?.find(
+			(step: any) => step?.step === 'installTheme'
+		);
+		expect(themeStep).toBeDefined();
+		expect((themeStep as any)?.themeData?.slug).toBe('flavor');
+	});
+
+	it('sets landingPage from ?url= param via applyQueryOverrides', async () => {
+		const url = new URL(
+			'https://playground.wordpress.net/?plugin=woocommerce&url=/wp-admin/plugins.php'
+		);
+		const result = await resolveUrlParamsForExistingSite(url);
+
+		expect(result).not.toBeNull();
+		expect(result?.landingPage).toBe('/wp-admin/plugins.php');
+	});
+
+	it('returns null for ?gutenberg-pr= (not supported for existing sites)', async () => {
+		const url = new URL(
+			'https://playground.wordpress.net/?gutenberg-pr=12345'
+		);
+		const result = await resolveUrlParamsForExistingSite(url);
+		expect(result).toBeNull();
+	});
+});

packages/playground/personal-wp/src/lib/personalwp/index.ts

@@ -2,6 +2,7 @@ import type { BlueprintV1Declaration } from '@wp-playground/client';
 import {
 	type ResolvedBlueprint,
 	resolveBlueprintFromURL,
+	applyQueryOverrides,
 } from '../state/url/resolve-blueprint-from-url';
 import {
 	getBlueprintDeclaration,
@@ -79,9 +80,6 @@ const ACTIONABLE_URL_PARAMS = [
 	'import-site',
 	'import-wxr',
 	'import-content',
-	'gutenberg-pr',
-	'gutenberg-branch',
-	'core-pr',
 ];
 
 /**
@@ -109,9 +107,14 @@ export async function resolveUrlParamsForExistingSite(
 	try {
 		const resolved = await resolveBlueprintFromURL(url, undefined);
 		// Extract the blueprint declaration from the bundle if needed
-		const blueprint = isBlueprintBundle(resolved.blueprint)
+		let blueprint = isBlueprintBundle(resolved.blueprint)
 			? await getBlueprintDeclaration(resolved.blueprint)
 			: (resolved.blueprint as BlueprintV1Declaration);
+		// Apply query overrides (e.g., ?url= for landing page, ?login=, etc.)
+		blueprint = (await applyQueryOverrides(
+			blueprint,
+			url.searchParams
+		)) as BlueprintV1Declaration;
 		return blueprint;
 	} catch (e) {
 		logger.error('Error resolving URL blueprint for existing site:', e);

packages/playground/personal-wp/src/lib/state/redux/boot-site-client.ts

@@ -366,6 +366,9 @@ export function bootSiteClient(
 				const current = blueprint as BlueprintV1Declaration;
 				blueprint = {
 					...blueprint,
+					...(resolved.plugins?.length
+						? { plugins: resolved.plugins }
+						: {}),
 					landingPage: resolved.landingPage || current.landingPage,
 					steps: [
 						...(current.steps || []),