-
Notifications
You must be signed in to change notification settings - Fork 295
404 errors for missing assets/scripts when running yarn run dev
#154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for the report! It looks like it can’t find some static files from But the You can restore these files by rebuilding WordPress:
I’m traveling to Rust now and can’t push a fix, but if you’d start a PR then I would merge it! |
Makes sense. That doesn't explain the first error with the missing SVG file though, as that one exists: https://github.com/WordPress/wordpress-playground/blob/b60ea1625ecec159cac0e9585e1edebdd786751b/packages/playground/remote/public/wp-6.1/wp-admin/images/about-header-about.svg Aside: seems weird to have full copies of all WP versions in the repo. Maybe those should be git submodules or separate packages or something? |
The SVG gets removed somewhere in the WP build process, unfortunately, it would be good to retain it. The dist/ issue is fixed in 70e5aa4. As for the full copies – I agree it's weird. They're here for now to reduce the initial setup hurdle but I'd like to offer that benefit without those files in the repo. |
This is now resolved, and the issue related to keeping the full copies of source files is tracked separately in #58 |
First of all, kudos to this new setup. I just tried
yarn build
followed byyarn run dev
and it's very fast! Very nice experience.What caught my eye though when opening the playground site is errors about some seemingly missing files:
The text was updated successfully, but these errors were encountered: