CPLAT-6014 Fix Dart2 RTE #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List<dynamic> is not a valid subtype of List<String> was being thrown when the `args` generated within `_getChildPids` was passed to the `TaskProcess` constructor.
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaronlademann-wf
force-pushed
the
fix-dart2-rte
branch
from
19c3d42 to
915cce5
Compare
greglittlefield-wf
approved these changes
Jun 5, 2019
| @@ -77,7 +77,7 @@ class TaskProcess { | |||
| pids = pids ?? [_process.pid]; | |||
| String executable = 'pgrep'; | |||
| List<TaskProcess> pgreps = []; | |||
| var args = []; | |||
| List<String> args = []; | |||
There was a problem hiding this comment.
fyi the other option here would be var/final args = <String>[];
evanweible-wf
approved these changes
Jun 11, 2019
|
QA +1
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A RTE is encountered by consumers when utilizing
dart_dev'sTaskProcessin Dart 2.This is thrown as a result of the
argsgenerated within_getChildPidsbeing passed to theTaskProcessconstructor.Solution
6900490
Boy Scoutin'
.gitignoreto include the.dart_tooldirectory@evanweible-wf @corwinsheahan-wf @greglittlefield-wf