Skip to content

Commit f5abcf2

Browse files
Apply suggestions from code review
Co-authored-by: Greg Littlefield <[email protected]>
1 parent a8d1e2a commit f5abcf2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/over_react/util/prop_conversion_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,7 @@ main() {
608608
});
609609
});
610610

611-
group('Map props using (un)jsifyMapListProp', () {
611+
group('List<Map> props using (un)jsifyMapListProp', () {
612612
group('get converted to JS objects', () {
613613
group('in the setter, and gets unconverted in getter', () {
614614
// This case is a little redundant with the (un)jsifyMapListProp tests above, but include it for completeness.
@@ -685,7 +685,7 @@ main() {
685685
});
686686

687687
group('and then reading a nested value that gets unconverted:', () {
688-
group('A nested map prop', () {
688+
group('A nested map list prop', () {
689689
test('using the typed props map', () {
690690
final builder = TestJs()
691691
..listOfProps = [
@@ -733,7 +733,7 @@ main() {
733733
reason:
734734
'test setup: should have converted to a JS object for storage in props map');
735735

736-
// For this test, it's important to mutate the original `listOfProps` Map passed into `builder.listOfProps`,
736+
// For this test, it's important to mutate the original `listOfProps` List passed into `builder.listOfProps`,
737737
// and not the value returned from the `builder.listOfProps` getter.
738738
listOfProps[0]['data-foo'] = 'bar';
739739
expect(builder.listOfProps, [isEmpty]);

0 commit comments

Comments
 (0)