Enhance version comparison logic in workflow

Author: YBTopaz8

.github/workflows/dotnet-desktop.yml

@@ -37,45 +37,50 @@ jobs:
           # --- A. READ CURRENT VERSION FROM FILE ---
           $projectFile = Get-ChildItem -Recurse -Filter "Dimmer.csproj" | Select-Object -First 1
           if (-not $projectFile) { Write-Error "❌ Dimmer.csproj not found"; exit 1 }
-
+          
           [xml]$xml = Get-Content $projectFile.FullName
           $currentVersionStr = $xml.Project.PropertyGroup.Version.Trim()
           
           if ([string]::IsNullOrWhiteSpace($currentVersionStr)) {
             Write-Error "❌ No <Version> tag found in Dimmer.csproj."
             exit 1
           }
-
+          
           $newTag = "v$currentVersionStr"
           Write-Host "🔹 Current File Version: $currentVersionStr"
           echo "NEW_TAG=$newTag" >> $env:GITHUB_ENV
-
+          
           # --- B. FIND PREVIOUS TAG ---
           git fetch --tags --force
           
-          # Get all tags, exclude the NEW tag explicitly (Trim ensures exact match)
+          # Get all tags
           $allTags = git tag --sort=-version:refname 
-          $prevTag = $allTags | Where-Object { $_.Trim() -ne $newTag } | Select-Object -First 1
-
+          
+          # Filter: Exclude current tag AND ensure tag looks like a standard version (e.g. v1.0, 1.0.5)
+          # This ignores tags like "v1.92a" which cause the crash
+          $validPattern = "^v?\d+(\.\d+)+$"
+          $prevTag = $allTags | Where-Object { $_.Trim() -ne $newTag -and $_.Trim() -match $validPattern } | Select-Object -First 1
+          
           if ([string]::IsNullOrWhiteSpace($prevTag)) {
-            Write-Host "⚠️ No previous tag found. Defaulting to Release."
+            Write-Host "⚠️ No previous standard tag found. Treating as first STABLE release."
             echo "IS_PRE=false" >> $env:GITHUB_ENV
             echo "LATEST_TAG=" >> $env:GITHUB_ENV
-            # Don't exit here, let it continue to set IS_PRE
           } else {
-            Write-Host "🔹 Previous Tag found: $prevTag"
+            Write-Host "🔹 Previous Valid Tag found: $prevTag"
             echo "LATEST_TAG=$prevTag" >> $env:GITHUB_ENV
           }
-
+          
           # --- C. COMPARE VERSIONS ---
           if ($prevTag) {
-            $prevVersionStr = $prevTag -replace "^v", ""
+            # Sanitize: Remove 'v' and anything that isn't a number or dot
+            $prevVersionStr = $prevTag -replace "[^0-9\.]", ""
+            
             try {
               $curV = [System.Version]$currentVersionStr
               $prevV = [System.Version]$prevVersionStr
-
+              
               Write-Host "Comparing $curV vs $prevV"
-
+              
               if ($curV.Major -gt $prevV.Major -or $curV.Minor -gt $prevV.Minor) {
                   Write-Host "🚀 Major/Minor change. Marking as STABLE RELEASE."
                   echo "IS_PRE=false" >> $env:GITHUB_ENV
@@ -84,12 +89,9 @@ jobs:
                   echo "IS_PRE=true" >> $env:GITHUB_ENV
               }
             } catch {
-              Write-Warning "Could not parse versions. Defaulting to Pre-Release."
+              Write-Warning "Could not parse versions despite sanitization. Defaulting to Pre-Release."
               echo "IS_PRE=true" >> $env:GITHUB_ENV
             }
-          } else {
-             # If no previous tag, assume it's a first release (Stable)
-             echo "IS_PRE=false" >> $env:GITHUB_ENV
           }
 
       # 3.5 GENERATE CHANGELOG (FIXED with Fallback)