Avoid boxing enum (dotnet#9001)

davkean · YuliiaKovalova · commit af4a811ebc6a · 2023-07-18T13:10:36.000+02:00
Fixes AB#1848255

On .NET Framework this boxes an enum, and allocated 600 MB in a trace I was looking at.
diff --git a/src/Build/Evaluation/Evaluator.cs b/src/Build/Evaluation/Evaluator.cs
@@ -2522,7 +2522,7 @@ private string GetCurrentDirectoryForConditionEvaluation(ProjectElement element)
 
         private void RecordEvaluatedItemElement(ProjectItemElement itemElement)
         {
-            if (_loadSettings.HasFlag(ProjectLoadSettings.RecordEvaluatedItemElements))
+            if ((_loadSettings & ProjectLoadSettings.RecordEvaluatedItemElements) == ProjectLoadSettings.RecordEvaluatedItemElements)
             {
                 _data.EvaluatedItemElements.Add(itemElement);
             }

Original file line number	Diff line number	Diff line change
`@@ -2522,7 +2522,7 @@ private string GetCurrentDirectoryForConditionEvaluation(ProjectElement element)`
`2522`	`2522`
`2523`	`2523`	`private void RecordEvaluatedItemElement(ProjectItemElement itemElement)`
`2524`	`2524`	`{`
`2525`		`- if (_loadSettings.HasFlag(ProjectLoadSettings.RecordEvaluatedItemElements))`
	`2525`	`+ if ((_loadSettings & ProjectLoadSettings.RecordEvaluatedItemElements) == ProjectLoadSettings.RecordEvaluatedItemElements)`
`2526`	`2526`	`{`
`2527`	`2527`	`_data.EvaluatedItemElements.Add(itemElement);`
`2528`	`2528`	`}`