fix: a2a_mcp example in python3 #224
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @kyoto7250, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on modernizing and improving the a2a_mcp Python example. It addresses Python 3 compatibility by updating core dependencies and adapting the code to new API patterns. Furthermore, it significantly enhances the developer experience by providing clearer documentation for running the example and introducing new CLI capabilities for direct tool interaction.
Highlights
- Python 3 Compatibility & SDK Update: The
a2a_mcpexample has been updated to ensure full compatibility and functionality with Python 3. This involved upgrading thea2a-sdkdependency to version0.2.11(includingsqlfeatures) and adapting the push notification handling insrc/a2a_mcp/agents/__main__.pyto align with the latest SDK API. - Improved CLI Execution Instructions: The
README.mdnow provides more accurate and comprehensive command-line instructions for running thea2a_mcpserver and its various agents. This includes adding--env-file .envtouv runcommands for consistency and providing a detailed example for starting the CLI client. - Enhanced Client Tool Execution: The
src/a2a_mcp/mcp/client.pyscript has been enhanced with a new--tool_nameCLI option. This allows users to directly execute specific tools such assearch_flights,search_hotels, orquery_db(which has been internally renamed toquery_travel_data). - Tool Renaming: The
query_dbtool's internal identifier has been updated toquery_travel_datawithin thesrc/a2a_mcp/mcp/client.pyimplementation, affecting thesession.call_toolargument and related logging.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR fixes the a2a-mcp example for Python 3. It updates dependencies, aligns with API changes in a2a-sdk, improves the README with clearer CLI instructions, and adds a new CLI option to execute specific tools. There are some inconsistencies in the README's command examples, and discrepancies in the function's docstring and implementation in the client script. Addressing these will improve documentation clarity and code correctness.
| @@ -160,14 +162,14 @@ async def query_db(session: ClientSession) -> CallToolResult: | |||
|
|
|||
| Args: | |||
There was a problem hiding this comment.
The docstring for query_db lists a query parameter, but the function signature async def query_db(session: ClientSession) does not accept it. This discrepancy between the documentation and the implementation is misleading.
Since the function currently uses a hardcoded SQL query for testing purposes, the query parameter should be removed from the docstring to accurately reflect the function's signature.
There was a problem hiding this comment.
I don't think there is any need to change the existing implementation,
and I'd like to hear the maintainers' opinions on this.
| @@ -160,14 +162,14 @@ async def query_db(session: ClientSession) -> CallToolResult: | |||
|
|
|||
| Args: | |||
There was a problem hiding this comment.
The argument description for query is inaccurate, as it refers to search_hotels tool, which is not relevant in this context. It should refer to the query_db tool instead.
| Args: | |
| query: The natural language query to send to the 'query_db' tool. |
Currently
a2a-mcpis not worked.so, this PR fixes
a2a-mcpon Python 3 to make it work.Changes:
a2a_mcp/src/a2a_mcp/agents/main.pyto align with refactor!: Push notification changes a2a-python#212tool_nameparameter to CLI, as missing this argument would result in an error.Not Addressed:
Regarding uv upload-time, please refer to:
astral-sh/uv#12968