Skip to content

ContentType.FormData no longer sets the correct boundary #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Styn opened this issue Feb 18, 2021 · 4 comments · Fixed by #173 or #175
Closed

ContentType.FormData no longer sets the correct boundary #172

Styn opened this issue Feb 18, 2021 · 4 comments · Fixed by #173 or #175
Assignees
@Styn
Labels
bug Something isn't working good first issue Good for newcomers next release

Comments

@Styn
Copy link
Contributor

Styn commented Feb 18, 2021

This PR: 29d89ec
breaks the boundary setting for FormData.

Right now the header will look like this: Content-Type: multipart/form-data instead of something like Content-Type: multipart/form-data; boundary=----WebKitFormBoundaryUAzmDsnaGSk1qaI3
@js2me js2me added bug Something isn't working good first issue Good for newcomers next release labels Feb 18, 2021
@js2me
Copy link
Member

js2me commented Feb 18, 2021

Hello @Styn !
Thanks for this issue, can you fix that problem and create PR ?

@js2me
Copy link
Member

js2me commented Feb 18, 2021

Or if not, don't worry I'll fix that but I need a bit more time

@Styn
Copy link
Contributor Author

Styn commented Feb 18, 2021

I'll have a PR up soon

@Styn Styn mentioned this issue Feb 18, 2021
Merged
@js2me js2me mentioned this issue Feb 19, 2021
Merged
@js2me js2me linked a pull request Feb 19, 2021 that will close this issue
Release 5.1.5 #175
Merged
@js2me
Copy link
Member

js2me commented Feb 19, 2021

@Styn fixed in 5.1.5, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Styn Styn

Labels
bug Something isn't working good first issue Good for newcomers next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't set multipart/form-data content-type
Release 5.1.5 acacode/swagger-typescript-api
2 participants
@Styn @js2me