Skip to content

New fork swagger-typescript-api-nextgen with extra features and fixes #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
grandsilence opened this issue May 16, 2022 · 5 comments
Closed

Comments

@grandsilence
Copy link

Please check out my fork: swagger-typescript-api-nextgen, maybe it will be useful for those who need a secure version with updated dependencies, as well as support for current axios and other fixes.

The package is present in the npm (swagger-typescript-api-nextgen).

✨ The fork key differences

@andersfylling
Copy link

Is there a reason these changes aren't a PR for swagger-typescript-api project?

@grandsilence
Copy link
Author

@andersfylling PR for a long time aren't accepted, the project seems to be abandoned.

@bartvanandel
Copy link

Looks like recently, activity is returning to this repo. Maybe this would be a good time to have the changes merged back into this original repo?

@js2me
Copy link
Member

js2me commented Oct 28, 2022

Hi @grandsilence , your fork looks good !
This project is not abandoned, just I didn't have time to work on it :)
If you want to improve your fork, please merge the latest version of swagger-typescript-api, cause I fixed a lot of bugs and add a lot of features :)

@js2me js2me closed this as completed Oct 28, 2022
@moteey
Copy link

moteey commented Jan 13, 2023

Hi @js2me,
First of all, thanks for the great work on the generator.

I am currently using the nextgen package, but would love to switch back to the original one. That being said, the main reason I started using the swagger-typescript-api-nextgen was this change:

templates/base/http-clients/axios-http-client.eta

- import axios, { AxiosInstance, AxiosRequestConfig, AxiosResponse, ResponseType } from "axios";
+ import type { AxiosInstance, AxiosRequestConfig, AxiosResponse, ResponseType } from "axios";
+ import axios from "axios";

For my project, not using type modifiers for type-only imports throws errors, because of the following tsconfig.json options:

{
  "compilerOptions": {
    "preserveValueImports": true,
    "importsNotUsedAsValues": "error",
  }
}

These are default (and I believe encessary) options for Vite + Vue projects.

Is there any chance this could make it into one of the following versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants