Skip to content

Optional CodeFormatter #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
offbeatful opened this issue May 4, 2023 · 2 comments · Fixed by #1145
Closed

Optional CodeFormatter #525

offbeatful opened this issue May 4, 2023 · 2 comments · Fixed by #1145
Labels
enhancement New feature or request

Comments

@offbeatful
Copy link

Thank you for the awesome library!

It would be even better if formatting comes optional. Reasons:

  1. Not all of us use Prettier
  2. Sometimes I just want to disable formatting at all.
  3. Performance (in my tests it is 358ms vs 60ms without formatting) on petstore swagger

Ideally I want to pass my own instance of CodeFormatter or null.

@smorimoto
Copy link
Collaborator

Now the performance improvements have been made by replacing Prettier with Biome, and disabling the formatter is an option worth exploring, but is not a high priority at the moment.

@offbeatful
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants