feat: currency conversion monitor

Author: achannarasappa

internal/asset/asset.go

@@ -30,7 +30,7 @@ func GetAssets(ctx c.Context, assetGroupQuote c.AssetGroupQuote) ([]c.Asset, Hol
 
 	for i, assetQuote := range assetGroupQuote.AssetQuotes {
 
-		currencyRateByUse := currency.GetCurrencyRateFromContext(ctx, assetQuote.Currency.FromCurrencyCode)
+		currencyRateByUse := currency.GetCurrencyRateFromContext(ctx, assetQuote.Currency.FromCurrencyCode, assetQuote.Currency.ToCurrencyCode, assetQuote.Currency.Rate)
 
 		holding := getHoldingFromAssetQuote(assetQuote, holdingsBySymbol, currencyRateByUse)
 		holdingSummary = addHoldingToHoldingSummary(holdingSummary, holding, currencyRateByUse)

internal/cli/cli.go

@@ -7,7 +7,6 @@ import (
 
 	"github.com/achannarasappa/ticker/v4/internal/cli/symbol"
 	c "github.com/achannarasappa/ticker/v4/internal/common"
-	"github.com/achannarasappa/ticker/v4/internal/quote"
 	yahooClient "github.com/achannarasappa/ticker/v4/internal/quote/yahoo/client"
 	"github.com/achannarasappa/ticker/v4/internal/ui/util"
 
@@ -138,10 +137,11 @@ func readConfig(fs afero.Fs, configPathOption string) (c.Config, error) {
 
 func getReference(config c.Config, assetGroups []c.AssetGroup, client *resty.Client) (c.Reference, error) {
 
-	currencyRates, err := quote.GetAssetGroupsCurrencyRates(client, assetGroups, config.Currency)
-	if err != nil {
-		return c.Reference{}, err
-	}
+	var err error
+	// currencyRates, err := quote.GetAssetGroupsCurrencyRates(client, assetGroups, config.Currency)
+	// if err != nil {
+	// 	return c.Reference{}, err
+	// }
 
 	styles := util.GetColorScheme(config.ColorScheme)
 
@@ -150,8 +150,8 @@ func getReference(config c.Config, assetGroups []c.AssetGroup, client *resty.Cli
 	}
 
 	return c.Reference{
-		CurrencyRates: currencyRates,
-		Styles:        styles,
+		// CurrencyRates: currencyRates,
+		Styles: styles,
 	}, err
 
 }

internal/common/common.go

@@ -87,6 +87,12 @@ type Monitor interface {
 	Stop() error
 }
 
+type MonitorCurrencyRate interface {
+	Start() error
+	SetTargetCurrency(targetCurrency string)
+	Stop() error
+}
+
 // Lot represents a cost basis lot
 type Lot struct {
 	Symbol    string  `yaml:"symbol"`
@@ -257,3 +263,9 @@ type MessageUpdate[T any] struct {
 	Sequence int64
 	Nonce    int
 }
+
+type MessageRequest[T any] struct {
+	Data  T
+	ID    string
+	Nonce int
+}

internal/currency/currency.go

@@ -14,55 +14,53 @@ type CurrencyRateByUse struct { //nolint:golint,revive
 }
 
 // GetCurrencyRateFromContext reads currency rates from the context and sets the conversion rate for each use case
-func GetCurrencyRateFromContext(ctx c.Context, fromCurrency string) CurrencyRateByUse {
+func GetCurrencyRateFromContext(ctx c.Context, fromCurrency string, toCurrency string, rate float64) CurrencyRateByUse {
 
-	// If currency is convertible
-	if currencyRate, ok := ctx.Reference.CurrencyRates[fromCurrency]; ok {
-
-		currencyRateCost := currencyRate.Rate
-
-		if ctx.Config.CurrencyDisableUnitCostConversion {
-			currencyRateCost = 1.0
+	if rate == 0 {
+		return CurrencyRateByUse{
+			ToCurrencyCode: fromCurrency,
+			QuotePrice:     1.0,
+			PositionCost:   1.0,
+			SummaryValue:   1.0,
+			SummaryCost:    1.0,
 		}
+	}
 
-		// Convert only the summary currency to the configured currency
-		if ctx.Config.Currency != "" && ctx.Config.CurrencyConvertSummaryOnly {
-			return CurrencyRateByUse{
-				ToCurrencyCode: fromCurrency,
-				QuotePrice:     1.0,
-				PositionCost:   1.0,
-				SummaryValue:   currencyRate.Rate,
-				SummaryCost:    currencyRateCost,
-			}
-		}
+	currencyRateCost := rate
 
-		// Convert all quotes and positions to target currency and implicitly convert summary currency (i.e. no conversion since underlying values are already converted)
-		if ctx.Config.Currency != "" {
-			return CurrencyRateByUse{
-				ToCurrencyCode: currencyRate.ToCurrency,
-				QuotePrice:     currencyRate.Rate,
-				PositionCost:   currencyRateCost,
-				SummaryValue:   1.0,
-				SummaryCost:    1.0,
-			}
-		}
+	if ctx.Config.CurrencyDisableUnitCostConversion {
+		currencyRateCost = 1.0
+	}
 
-		// Convert only the summary currency to the default currency (USD) when currency conversion is not enabled
+	// Convert only the summary currency to the configured currency
+	if ctx.Config.Currency != "" && ctx.Config.CurrencyConvertSummaryOnly {
 		return CurrencyRateByUse{
-			ToCurrencyCode: currencyRate.ToCurrency,
+			ToCurrencyCode: fromCurrency,
 			QuotePrice:     1.0,
 			PositionCost:   1.0,
-			SummaryValue:   currencyRate.Rate,
+			SummaryValue:   rate,
 			SummaryCost:    currencyRateCost,
 		}
+	}
 
+	// Convert all quotes and positions to target currency and implicitly convert summary currency (i.e. no conversion since underlying values are already converted)
+	if ctx.Config.Currency != "" {
+		return CurrencyRateByUse{
+			ToCurrencyCode: toCurrency,
+			QuotePrice:     rate,
+			PositionCost:   currencyRateCost,
+			SummaryValue:   1.0,
+			SummaryCost:    1.0,
+		}
 	}
 
+	// Convert only the summary currency to the default currency (USD) when currency conversion is not enabled
 	return CurrencyRateByUse{
-		ToCurrencyCode: fromCurrency,
+		ToCurrencyCode: toCurrency,
 		QuotePrice:     1.0,
 		PositionCost:   1.0,
-		SummaryValue:   1.0,
-		SummaryCost:    1.0,
+		SummaryValue:   rate,
+		SummaryCost:    currencyRateCost,
 	}
+
 }

internal/currency/currency_test.go

@@ -28,7 +28,7 @@ var _ = Describe("Currency", func() {
 					},
 				},
 			}
-			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "EUR")
+			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "EUR", "USD", 0)
 			Expect(outputCurrencyRateByUse.QuotePrice).To(Equal(1.0))
 			Expect(outputCurrencyRateByUse.PositionCost).To(Equal(1.0))
 			Expect(outputCurrencyRateByUse.SummaryValue).To(Equal(1.0))
@@ -58,7 +58,7 @@ var _ = Describe("Currency", func() {
 					},
 				},
 			}
-			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "USD")
+			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "USD", "EUR", 0)
 			Expect(outputCurrencyRateByUse.QuotePrice).To(Equal(1.25))
 			Expect(outputCurrencyRateByUse.PositionCost).To(Equal(1.25))
 			Expect(outputCurrencyRateByUse.SummaryValue).To(Equal(1.0))
@@ -88,7 +88,7 @@ var _ = Describe("Currency", func() {
 					},
 				},
 			}
-			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "USD")
+			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "USD", "EUR", 0)
 			Expect(outputCurrencyRateByUse.QuotePrice).To(Equal(1.0))
 			Expect(outputCurrencyRateByUse.PositionCost).To(Equal(1.0))
 			Expect(outputCurrencyRateByUse.SummaryValue).To(Equal(1.25))
@@ -119,7 +119,7 @@ var _ = Describe("Currency", func() {
 					},
 				},
 			}
-			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "USD")
+			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "USD", "EUR", 0)
 			Expect(outputCurrencyRateByUse.QuotePrice).To(Equal(1.0))
 			Expect(outputCurrencyRateByUse.PositionCost).To(Equal(1.0))
 			Expect(outputCurrencyRateByUse.SummaryValue).To(Equal(1.25))
@@ -150,7 +150,7 @@ var _ = Describe("Currency", func() {
 					},
 				},
 			}
-			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "USD")
+			outputCurrencyRateByUse := GetCurrencyRateFromContext(inputCtx, "USD", "EUR", 0)
 			Expect(outputCurrencyRateByUse.SummaryCost).To(Equal(1.0))
 			Expect(outputCurrencyRateByUse.PositionCost).To(Equal(1.0))
 		})