feat: skip conversion of exchange rates

Author: achannarasappa

internal/asset/asset.go

@@ -46,7 +46,7 @@ func GetAssets(ctx c.Context, assetGroupQuote c.AssetGroupQuote) ([]c.Asset, Pos
 
 	for _, assetQuote := range assetGroupQuote.AssetQuotes {
 
-		currencyRateByUse := getCurrencyRateByUse(ctx, assetQuote.Currency.FromCurrencyCode, assetQuote.Currency.ToCurrencyCode, assetQuote.Currency.Rate)
+		currencyRateByUse := getCurrencyRateByUse(ctx, assetQuote.Class, assetQuote.Currency.FromCurrencyCode, assetQuote.Currency.ToCurrencyCode, assetQuote.Currency.Rate)
 
 		position := getPositionFromAssetQuote(assetQuote, lotsBySymbol, currencyRateByUse)
 		positionSummary = addPositionToPositionSummary(positionSummary, position, currencyRateByUse)

internal/asset/currency.go

@@ -14,7 +14,18 @@ type currencyRateByUse struct { //nolint:golint,revive
 }
 
 // getCurrencyRateByUse reads currency rates from the context and sets the conversion rate for each use case
-func getCurrencyRateByUse(ctx c.Context, fromCurrency string, toCurrency string, rate float64) currencyRateByUse {
+func getCurrencyRateByUse(ctx c.Context, assetClass c.AssetClass, fromCurrency string, toCurrency string, rate float64) currencyRateByUse {
+
+	// Skip currency conversion for currency pairs (e.g., KRW=X) when explicitly watched
+	if assetClass == c.AssetClassCurrency {
+		return currencyRateByUse{
+			ToCurrencyCode: fromCurrency,
+			QuotePrice:     1.0,
+			PositionCost:   1.0,
+			SummaryValue:   1.0,
+			SummaryCost:    1.0,
+		}
+	}
 
 	if rate == 0 {
 		return currencyRateByUse{

internal/asset/currency_test.go

@@ -338,5 +338,53 @@ var _ = Describe("Currency", func() {
 			})
 
 		})
+
+		When("a currency pair is explicitly watched", func() {
+			It("should not convert currency even when currency conversion is enabled", func() {
+				inputCtx := c.Context{
+					Config: c.Config{
+						Currency: "EUR",
+					},
+					Reference: c.Reference{},
+				}
+				assetGroupQuote := c.AssetGroupQuote{
+					AssetGroup: c.AssetGroup{
+						ConfigAssetGroup: c.ConfigAssetGroup{
+							Lots: []c.Lot{
+								{
+									Symbol:   "KRW=X",
+									Quantity: 1000,
+									UnitCost: 0.00075, // Cost in USD
+								},
+							},
+						},
+					},
+					AssetQuotes: []c.AssetQuote{
+						{
+							Symbol: "KRW=X",
+							Class:  c.AssetClassCurrency,
+							Currency: c.Currency{
+								FromCurrencyCode: "USD",
+								ToCurrencyCode:   "EUR",
+								Rate:             1.25, // This rate should be ignored for currency pairs
+							},
+							QuotePrice: c.QuotePrice{
+								Price: 0.00075, // Exchange rate: 1 KRW = 0.00075 USD
+							},
+						},
+					},
+				}
+				assets, summary := GetAssets(inputCtx, assetGroupQuote)
+
+				Expect(assets).To(HaveLen(1))
+				Expect(assets[0].Currency.FromCurrencyCode).To(Equal("USD"))
+				Expect(assets[0].Currency.ToCurrencyCode).To(Equal("USD")) // Should remain USD, not converted to EUR
+				Expect(assets[0].QuotePrice.Price).To(Equal(0.00075))      // No conversion applied
+				Expect(assets[0].Position.Value).To(Equal(0.75))            // 1000 * 0.00075, no conversion
+				Expect(assets[0].Position.Cost).To(Equal(0.75))            // No conversion applied
+				Expect(summary.Value).To(Equal(0.75))                       // No conversion applied
+				Expect(summary.Cost).To(Equal(0.75))                        // No conversion applied
+			})
+		})
 	})
 })

internal/common/common.go

@@ -236,6 +236,7 @@ const (
 	AssetClassPrivateSecurity
 	AssetClassUnknown
 	AssetClassFuturesContract
+	AssetClassCurrency
 )
 
 type QuoteSource int

internal/monitor/yahoo/unary/helpers-quote.go

@@ -126,6 +126,10 @@ func getAssetClass(assetClass string) c.AssetClass {
 		return c.AssetClassCryptocurrency
 	}
 
+	if assetClass == "CURRENCY" {
+		return c.AssetClassCurrency
+	}
+
 	return c.AssetClassStock
 
 }

internal/monitor/yahoo/unary/unary_test.go

@@ -160,6 +160,47 @@ var _ = Describe("Unary", func() {
 			Expect(outputError).To(BeNil())
 		})
 
+		It("should return the asset class as a currency", func() {
+			// Create a new response to avoid mutating the shared fixture
+			resp := unary.Response{
+				QuoteResponse: unary.ResponseQuoteResponse{
+					Quotes: []unary.ResponseQuote{
+						{
+							MarketState:                "REGULAR",
+							ShortName:                  "KRW/USD",
+							PreMarketChange:            unary.ResponseFieldFloat{Raw: 0.0, Fmt: "0.0"},
+							PreMarketChangePercent:     unary.ResponseFieldFloat{Raw: 0.0, Fmt: "0.0"},
+							PreMarketPrice:             unary.ResponseFieldFloat{Raw: 0.0, Fmt: "0.0"},
+							RegularMarketChange:        unary.ResponseFieldFloat{Raw: 0.00001, Fmt: "0.00001"},
+							RegularMarketChangePercent: unary.ResponseFieldFloat{Raw: 0.1, Fmt: "0.1"},
+							RegularMarketPrice:         unary.ResponseFieldFloat{Raw: 0.00075, Fmt: "0.00075"},
+							RegularMarketPreviousClose: unary.ResponseFieldFloat{Raw: 0.00074, Fmt: "0.00074"},
+							RegularMarketOpen:          unary.ResponseFieldFloat{Raw: 0.00074, Fmt: "0.00074"},
+							RegularMarketDayHigh:       unary.ResponseFieldFloat{Raw: 0.00076, Fmt: "0.00076"},
+							RegularMarketDayLow:        unary.ResponseFieldFloat{Raw: 0.00073, Fmt: "0.00073"},
+							PostMarketChange:           unary.ResponseFieldFloat{Raw: 0.0, Fmt: "0.0"},
+							PostMarketChangePercent:    unary.ResponseFieldFloat{Raw: 0.0, Fmt: "0.0"},
+							PostMarketPrice:            unary.ResponseFieldFloat{Raw: 0.0, Fmt: "0.0"},
+							Symbol:                     "KRW=X",
+							QuoteType:                  "CURRENCY",
+							Currency:                   "USD",
+						},
+					},
+					Error: nil,
+				},
+			}
+
+			appendQuoteHandler(server, "KRW=X", urlParams, resp)
+
+			outputSlice, _, outputError := client.GetAssetQuotes([]string{"KRW=X"})
+			Expect(outputSlice).To(g.MatchAllElementsWithIndex(g.IndexIdentity, g.Elements{
+				"0": g.MatchFields(g.IgnoreExtras, g.Fields{
+					"Class": Equal(c.AssetClassCurrency),
+				}),
+			}))
+			Expect(outputError).To(BeNil())
+		})
+
 		Context("session", func() {
 			When("the session is not set or is expired", func() {
 				It("should refresh the session and then retry the request", func() {