Skip to content

crate compile warnings treated as errors #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcandre opened this issue Apr 4, 2025 · 2 comments
Closed

crate compile warnings treated as errors #56

mcandre opened this issue Apr 4, 2025 · 2 comments

Comments

@mcandre
Copy link

mcandre commented Apr 4, 2025

Unlike on my local (macOS) machine, the same cargo install --force cross --git https://github.com/cross-rs/cross --rev 4e64366af6095c84fa4f54a0fa5a2ba7d9a271aa command with setup-rust-toolchain in GitHub Actions somehow treats crate warnings as errors.

This causes my jobs to fail when updating to Rust 1.86.0.

https://github.com/mcandre/crit/actions/runs/14273528463/job/40011901318

See also cross-rs/cross#1662

@Emilgardis
Copy link

Emilgardis commented Apr 4, 2025

This is expected default behaviour. You can unset the RUSTFLAGS env set by the action with the rustflags input

also #48

@jonasbb
Copy link
Member

jonasbb commented Apr 5, 2025

This is an unwanted side effect of setting the RUSTFLAGS environment variable. You find the reasoning better explained in #48. You can provide your own rustflags input or unset the RUSTFLAGS variable for the cargo install step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants