Skip to content

Commit babde17

Browse files
committed
Add integration test to validate base-url
1 parent e69ef54 commit babde17

File tree

2 files changed

+56
-2
lines changed

2 files changed

+56
-2
lines changed

.github/workflows/integration.yml

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,3 +248,54 @@ jobs:
248248
done <<< "$tests"
249249
250250
echo $'\u2705 Test passed' | tee -a $GITHUB_STEP_SUMMARY
251+
252+
test-base-url:
253+
name: 'Integration test: base-url option'
254+
runs-on: ubuntu-latest
255+
steps:
256+
- uses: actions/checkout@v3
257+
- uses: ./.github/actions/install-dependencies
258+
- id: base-url-default
259+
name: Default base-url not set
260+
uses: ./
261+
with:
262+
script: |
263+
const endpoint = github.request.endpoint
264+
return endpoint({}).url
265+
result-encoding: string
266+
- id: base-url-set
267+
name: base-url set
268+
uses: ./
269+
with:
270+
base-url: https://my.github-enterprise-server.com/api/v3
271+
script: |
272+
const endpoint = github.request.endpoint
273+
return endpoint({}).url
274+
result-encoding: string
275+
- id: base-url-env
276+
name: base-url does not override GITHUB_API_URL when not set
277+
uses: ./
278+
env:
279+
GITHUB_API_URL: https://my.github-enterprise-server.com/api/v3
280+
with:
281+
script: |
282+
const endpoint = github.request.endpoint
283+
return endpoint({}).url
284+
result-encoding: string
285+
- run: |
286+
echo "- Validating base-url default"
287+
expected="https://api.github.com"
288+
if [[ "${{steps.base-url-default.outputs.result}}" != "$expected" ]]; then
289+
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-default.outputs.result}}"
290+
exit 1
291+
fi
292+
echo "- Validating base-url set to a value"
293+
expected="https://my.github-enterprise-server.com/api/v3"
294+
if [[ "${{steps.base-url-set.outputs.result}}" != "$expected" ]]; then
295+
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-set.outputs.result}}"
296+
exit 1
297+
fi
298+
echo "- Validating base-url not set respects GITHUB_API_URL"
299+
expected="https://my.github-enterprise-server.com/api/v3"
300+
if [[ "${{steps.base-url-env.outputs.result}}" != "$expected" ]]; then
301+
echo $'::error::\u274C' "Expected base-url to start with '$expected', got ${{steps.base-url-env.outputs.result}}"

dist/index.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35509,11 +35509,14 @@ async function main() {
3550935509
userAgent: userAgent || undefined,
3551035510
previews: previews ? previews.split(',') : undefined,
3551135511
retry: retryOpts,
35512-
request: requestOpts,
35513-
baseUrl: baseUrl || undefined
35512+
request: requestOpts
3551435513
};
35514+
if (baseUrl) {
35515+
opts.baseUrl = baseUrl;
35516+
}
3551535517
const github = (0,lib_github.getOctokit)(token, opts, plugin_retry_dist_node.retry, dist_node.requestLog);
3551635518
const script = core.getInput('script', { required: true });
35519+
github.request.endpoint('GET /repos/{owner}/{repo}').url;
3551735520
// Using property/value shorthand on `require` (e.g. `{require}`) causes compilation errors.
3551835521
const result = await callAsyncFunction({
3551935522
require: wrapRequire,

0 commit comments

Comments
 (0)