Skip to content

Commit 6cf01cb

Browse files
L. Warren Thompsonclaude
authored andcommitted
Address review feedback: remove verbose comment and simplify release note
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 9cc5851 commit 6cf01cb

2 files changed

Lines changed: 1 addition & 7 deletions

File tree

packages/loot-core/src/shared/transactions.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -262,12 +262,6 @@ export function updateTransaction(
262262
) {
263263
return replaceTransactions(transactions, transaction.id, trans => {
264264
if (trans.is_parent) {
265-
// When updating the parent, merge the incoming fields with the
266-
// existing transaction so that properties like `amount`, `account`,
267-
// and `date` are preserved. A partial update (e.g. only setting
268-
// `notes`) must not discard existing values – otherwise
269-
// `recalculateSplit` sees `amount` as 0 and sets a
270-
// SplitTransactionError.
271265
const parent =
272266
trans.id === transaction.id ? { ...trans, ...transaction } : trans;
273267
const originalSubtransactions =

upcoming-release-notes/7242.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ category: Bugfixes
33
authors: [lwarrenthompson]
44
---
55

6-
Fix `api.updateTransaction()` corrupting split parent transactions when doing partial updates (e.g. only updating `notes`). Previously this would set a `SplitTransactionError` and could create zero-amount child rows.
6+
Fix `api.updateTransaction()` corrupting split parent transactions when doing partial updates

0 commit comments

Comments
 (0)