Skip to content

Commit 7adbb88

Browse files
authored
Merge pull request #65 from dhalbert/update-dis
Make DeviceInfoService handle remote services
2 parents eacb152 + d4ff50a commit 7adbb88

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

adafruit_ble/services/standard/device_info.py

+14-12
Original file line numberDiff line numberDiff line change
@@ -41,30 +41,32 @@
4141
class DeviceInfoService(Service):
4242
"""Device information"""
4343
uuid = StandardUUID(0x180a)
44-
default_field_name = "device_info"
4544
model_number = FixedStringCharacteristic(uuid=StandardUUID(0x2a24))
4645
serial_number = FixedStringCharacteristic(uuid=StandardUUID(0x2a25))
4746
firmware_revision = FixedStringCharacteristic(uuid=StandardUUID(0x2a26))
4847
hardware_revision = FixedStringCharacteristic(uuid=StandardUUID(0x2a27))
4948
software_revision = FixedStringCharacteristic(uuid=StandardUUID(0x2a28))
5049
manufacturer = FixedStringCharacteristic(uuid=StandardUUID(0x2a29))
5150

52-
def __init__(self, *, manufacturer,
53-
software_revision,
51+
def __init__(self, *,
52+
manufacturer=None,
53+
software_revision=None,
5454
model_number=None,
5555
serial_number=None,
5656
firmware_revision=None,
57-
hardware_revision=None):
58-
if model_number is None:
59-
model_number = sys.platform
60-
if serial_number is None:
61-
serial_number = binascii.hexlify(microcontroller.cpu.uid).decode('utf-8') # pylint: disable=no-member
62-
63-
if firmware_revision is None:
64-
firmware_revision = os.uname().version
57+
hardware_revision=None,
58+
service=None):
59+
if not service:
60+
if model_number is None:
61+
model_number = sys.platform
62+
if serial_number is None:
63+
serial_number = binascii.hexlify(microcontroller.cpu.uid).decode('utf-8') # pylint: disable=no-member
64+
if firmware_revision is None:
65+
firmware_revision = os.uname().version
6566
super().__init__(manufacturer=manufacturer,
6667
software_revision=software_revision,
6768
model_number=model_number,
6869
serial_number=serial_number,
6970
firmware_revision=firmware_revision,
70-
hardware_revision=hardware_revision)
71+
hardware_revision=hardware_revision,
72+
service=service)

0 commit comments

Comments
 (0)