From 9678a8e06ea7ffc980f2cd6f80a20c75631a1b25 Mon Sep 17 00:00:00 2001 From: SIDIK AL AMINI ZAILANI Date: Tue, 1 Mar 2022 16:19:09 +0800 Subject: [PATCH 1/3] Update adafruit_espatcontrol_socket.py I got error when using adafruit_espatcontrol_socket.py and adafruit_minimqtt when I use port 1883 for MQTT, it is due to connection type is not defined for port 1883 Traceback (most recent call last): File "code.py", line 117, in File "/lib/adafruit_minimqtt/adafruit_minimqtt.py", line 447, in connect File "/lib/adafruit_minimqtt/adafruit_minimqtt.py", line 270, in _get_connect_socket File "/lib/adafruit_espatcontrol/adafruit_espatcontrol_socket.py", line 85, in connect File "/lib/adafruit_espatcontrol/adafruit_espatcontrol.py", line 202, in socket_connect RuntimeError: Connection type must be TCP, UDL or SSL I propose to add conntype TCP for port 1883 --- adafruit_espatcontrol/adafruit_espatcontrol_socket.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/adafruit_espatcontrol/adafruit_espatcontrol_socket.py b/adafruit_espatcontrol/adafruit_espatcontrol_socket.py index aef2863..f0a46bb 100644 --- a/adafruit_espatcontrol/adafruit_espatcontrol_socket.py +++ b/adafruit_espatcontrol/adafruit_espatcontrol_socket.py @@ -73,6 +73,9 @@ def connect(self, address: Tuple[str, int], conntype: Optional[str] = None) -> N conntype = "TCP" elif port == 443: conntype = "SSL" + #to cater for MQTT over TCP + elif port == 1883 + conntype = "TCP" if not _the_interface.socket_connect( conntype, host, port, keepalive=10, retries=3 From 0eed6c1bf2f93c8651b196945edb5c7571b7587b Mon Sep 17 00:00:00 2001 From: SIDIK AL AMINI ZAILANI Date: Tue, 1 Mar 2022 16:24:32 +0800 Subject: [PATCH 2/3] Update adafruit_espatcontrol_socket.py missing : --- adafruit_espatcontrol/adafruit_espatcontrol_socket.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_espatcontrol/adafruit_espatcontrol_socket.py b/adafruit_espatcontrol/adafruit_espatcontrol_socket.py index f0a46bb..cff17da 100644 --- a/adafruit_espatcontrol/adafruit_espatcontrol_socket.py +++ b/adafruit_espatcontrol/adafruit_espatcontrol_socket.py @@ -74,7 +74,7 @@ def connect(self, address: Tuple[str, int], conntype: Optional[str] = None) -> N elif port == 443: conntype = "SSL" #to cater for MQTT over TCP - elif port == 1883 + elif port == 1883: conntype = "TCP" if not _the_interface.socket_connect( From 394bf962b92a760586436ac56da63e998a70fd63 Mon Sep 17 00:00:00 2001 From: SIDIK AL AMINI ZAILANI Date: Wed, 2 Mar 2022 00:57:40 +0800 Subject: [PATCH 3/3] Update adafruit_espatcontrol_socket.py add space after # --- adafruit_espatcontrol/adafruit_espatcontrol_socket.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_espatcontrol/adafruit_espatcontrol_socket.py b/adafruit_espatcontrol/adafruit_espatcontrol_socket.py index cff17da..2a09197 100644 --- a/adafruit_espatcontrol/adafruit_espatcontrol_socket.py +++ b/adafruit_espatcontrol/adafruit_espatcontrol_socket.py @@ -73,7 +73,7 @@ def connect(self, address: Tuple[str, int], conntype: Optional[str] = None) -> N conntype = "TCP" elif port == 443: conntype = "SSL" - #to cater for MQTT over TCP + # to cater for MQTT over TCP elif port == 1883: conntype = "TCP"