-
Notifications
You must be signed in to change notification settings - Fork 60
The CRC check doesn't catch all bad messages #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I intend to fix this by making the I also intend to put checks into the |
Would it be possible to fail in the same way as CRC if parse int or float fail? That way you still get an error but you only have one type of error to handle. |
I'm aiming to keep it so that the update() method behaviour stays the same, specifically |
Ok, that sounds perfect! Thank you! |
Because, the CRC value in the NMEA sentence is only 8-bit, it is fairly easy for a bad message to get past the CRC check.
By observation, with my GPS on the window it takes on average ~3 hours before a bad message crashes the program.
This is usually triggered by
_parse_int
and_parse_float
functions and can happen elsewhere.The text was updated successfully, but these errors were encountered: