Skip to content

Implement mov [DESTINATION], !x #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qbalsdon opened this issue Mar 19, 2021 · 3 comments
Closed

Implement mov [DESTINATION], !x #15

qbalsdon opened this issue Mar 19, 2021 · 3 comments
Assignees

Comments

@qbalsdon
Copy link

I would like to request the implementation of

mov [DESTINATION], !x

I would offer to do this myself but I actually have a) no idea what !x means (at least in this context) and b) don't know how to add to this repo (domain knowledge of the code)

@tannewt
Copy link
Member

tannewt commented Mar 19, 2021

Looks like it should work if you put a space inbetween ! x. The move parsing code is here: https://github.com/adafruit/Adafruit_CircuitPython_PIOASM/blob/main/adafruit_pioasm.py#L141-L147

To support !x you'd need to test to see if the source starts with !, ~ or :: and split accordingly.

@gamblor21 gamblor21 self-assigned this Mar 19, 2021
@kevinjwalters
Copy link

kevinjwalters commented Mar 19, 2021

FYI from https://learn.adafruit.com/intro-to-rp2040-pio-with-circuitpython#faq-3084251 under mov operator restrictions says:

The official dialect allows "!" to mean the same as "~". This is not accepted by adafruit_pioasm.

@gamblor21
Copy link
Member

Fixed in #17 if it still causes issues please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants