Skip to content

__getitem__ does not take advantage of slices #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gamblor21 opened this issue Dec 1, 2022 · 1 comment
Closed

__getitem__ does not take advantage of slices #2

gamblor21 opened this issue Dec 1, 2022 · 1 comment

Comments

@gamblor21
Copy link
Member

With the new slice get functionality getitem can be changed to not build the slice itself. The current python implementation is 50% slower then using the core code only.
@FoamyGuy FoamyGuy mentioned this issue Dec 2, 2022
Merged
@gamblor21
Copy link
Member Author

Fixed by #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gamblor21