Skip to content

Frequency change does not work. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerryneedell opened this issue May 23, 2018 · 2 comments
Closed

Frequency change does not work. #6

jerryneedell opened this issue May 23, 2018 · 2 comments

Comments

@jerryneedell
Copy link
Contributor

jerryneedell commented May 23, 2018

When the frequency is passed in to init it is incorrectly stored as
self.frequency
https://github.com/adafruit/Adafruit_CircuitPython_RFM69/blob/master/adafruit_rfm69.py#L343
but the actual "setter" is
self.frequnecy_mhz
https://github.com/adafruit/Adafruit_CircuitPython_RFM69/blob/master/adafruit_rfm69.py#L536
So that new frequency is not actually sent to the chip.

This is a similar issue found in the rfm9x driver and fixed there via adafruit/Adafruit_CircuitPython_RFM9x#4 . There were a few additional issues found in that may also be appropriate for this driver.

Posted in response to Forum post https://forums.adafruit.com/viewtopic.php?f=8&t=135989&p=674098#p674098

The default setting of 915 Mhz is in section 6.2 table 24 of the data sheet https://cdn-shop.adafruit.com/product-files/3076/RFM69HCW-V1.1.pdf

whereas the RFM9x defaults to 433Mhz - see section 6.1 table 85
https://cdn-learn.adafruit.com/assets/assets/000/031/659/original/RFM95_96_97_98W.pdf?1460518717

@jerryneedell
Copy link
Contributor Author

There is a simple workaround - just use the “setter” after initializing the radio.
rfm69 = adafruit_rfm69.RFM69(spi, CS, RESET, RADIO_FREQ_MHZ)
rfm69.frequency_mhz=RADIO_FREQ_MHZ

@jerryneedell
Copy link
Contributor Author

fixed by #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant