Skip to content

Incorporate fixes from https://github.com/micropython/micropython/pull/8459 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhalbert opened this issue Mar 29, 2022 · 3 comments
Closed

Incorporate fixes from https://github.com/micropython/micropython/pull/8459 #22

dhalbert opened this issue Mar 29, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@dhalbert
Copy link
Contributor

dhalbert commented Mar 29, 2022 •
edited by jepler
Loading

@dhalbert dhalbert added the bug Something isn't working label Mar 29, 2022
@dhalbert dhalbert mentioned this issue Mar 29, 2022
Merged
@jepler
Copy link
Contributor

jepler commented Oct 18, 2022

This is partially done in #30 but was incomplete.

@jepler jepler mentioned this issue Oct 18, 2022
Closed
@kbsriram
Copy link
Contributor

I could be wrong, but should this bug be closed? I wasn't able to spot any changes from the original commit that aren't either in this library or the core. Maybe the remaining changes intended (adding tests to circuitpython core?) made its way there as part of adafruit/circuitpython#8281 ?

@dhalbert
Copy link
Contributor Author

@kbsriram I think you're right, since we updated quite recently when we merged recent versions of MicroPython. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kbsriram @jepler @dhalbert