Skip to content

Commit cedbebb

Browse files
authored
Merge pull request #85 from demophoon/issue70/master/libraries-which-dont-require-blinka-🤖
Fix 'Blinka library required' false-positives
2 parents c399ada + 0ab010c commit cedbebb

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

adabot/lib/circuitpython_library_validators.py

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,19 @@
119119
# full name on Github (like Adafruit_CircuitPython_Bundle).
120120
BUNDLE_IGNORE_LIST = [BUNDLE_REPO_NAME]
121121

122-
LIBRARY_DOESNT_NEED_BLINKA = "Adafruit_CircuitPython_ImageLoad"
122+
LIBRARIES_DONT_NEED_BLINKA = [
123+
"Adafruit_CircuitPython_BusDevice",
124+
"Adafruit_CircuitPython_CircuitPlayground",
125+
"Adafruit_CircuitPython_FancyLED",
126+
"Adafruit_CircuitPython_IRRemote",
127+
"Adafruit_CircuitPython_ImageLoad",
128+
"Adafruit_CircuitPython_MCP9808",
129+
"Adafruit_CircuitPython_PCA9685",
130+
"Adafruit_CircuitPython_PCF8523",
131+
"Adafruit_CircuitPython_TLC59711",
132+
"Adafruit_CircuitPython_Waveform",
133+
"Adafruit_CircuitPython_miniQR",
134+
]
123135

124136
# Cache CircuitPython's subprojects on ReadTheDocs so its not fetched every repo check.
125137
rtd_subprojects = None
@@ -371,7 +383,7 @@ def _validate_requirements_txt(self, repo, file_info):
371383
lines = contents.text.split("\n")
372384
blinka_lines = [l for l in lines if re.match(r"[\s]*Adafruit-Blinka[\s]*", l)]
373385

374-
if not blinka_lines and repo["name"] not in LIBRARY_DOESNT_NEED_BLINKA:
386+
if not blinka_lines and repo["name"] not in LIBRARIES_DONT_NEED_BLINKA:
375387
errors.append(ERROR_MISSING_BLINKA)
376388
return errors
377389

0 commit comments

Comments
 (0)