nrf: disable interrupts before running wfi

Also, run background tasks with interrupts disabled.  This ensures
that any buffers are drained, and if an interrupt arrives after
buffers are drained but before the WFI is executed then the WFI
instruction will return immediately.

This fixes #2855 on NRF.

Signed-off-by: Sean Cross <[email protected]>

Author: xobs

ports/nrf/supervisor/port.c

@@ -247,7 +247,15 @@ void port_sleep_until_interrupt(void) {
         sd_app_evt_wait();
     } else {
         // Call wait for interrupt ourselves if the SD isn't enabled.
+        // Note that `wfi` should be called with interrupts disabled,
+        // to ensure that the queue is properly drained.  The `wfi`
+        // instruction will returned as long as an interrupt is
+        // available, even though the actual handler won't fire until
+        // we re-enable interrupts.
+        __disable_irq();
+        RUN_BACKGROUND_TASKS; // Drain any buffers remaining
         __WFI();
+        __enable_irq();
     }
 }