Commit c250b7d
authored
[Fizz] Should be considered complete inside onShellReady callback (facebook#33295)
We decremented `allPendingTasks` after invoking `onShellReady`. Which
means that in that scope it wasn't considered fully complete.
Since the pattern for flushing in Node.js is to start piping in
`onShellReady` and that's how you can get sync behavior, this led us to
think that we had more work left to do. For example we emitted the
`writeShellTimeInstruction` in this scenario before.1 parent 4448b18 commit c250b7d
File tree
2 files changed
+16
-1
lines changed- packages
- react-dom/src/__tests__
- react-server/src
2 files changed
+16
-1
lines changedLines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
70 | 85 | | |
71 | 86 | | |
72 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4335 | 4335 | | |
4336 | 4336 | | |
4337 | 4337 | | |
| 4338 | + | |
4338 | 4339 | | |
4339 | 4340 | | |
4340 | 4341 | | |
| |||
4417 | 4418 | | |
4418 | 4419 | | |
4419 | 4420 | | |
4420 | | - | |
4421 | 4421 | | |
4422 | 4422 | | |
4423 | 4423 | | |
| |||
0 commit comments