Skip to content

Commit d553212

Browse files
committed
Running tests with external redis (#5)
* updated `make test` to use a provided redis service vs building one and running it before executing the tests
1 parent be2e4d2 commit d553212

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

Makefile

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ PREFIX ?= /usr/local
66
LUA_INCLUDE_DIR ?= $(PREFIX)/include
77
LUA_LIB_DIR ?= $(PREFIX)/lib/lua/$(LUA_VERSION)
88
INSTALL ?= install
9-
TEST_NGINX_AWS_CLIENT_ID ?= ''
10-
TEST_NGINX_AWS_SECRET ?= ''
9+
REDIS_SERVER ?= $(BUILD_DIR)/redis-$(REDIS_VERSION)/src/redis-server
1110

1211
.PHONY: all clean test install
1312

@@ -22,6 +21,9 @@ install: all
2221
$(INSTALL) src/lua/api-gateway/tracking/validator/*.lua $(DESTDIR)/$(LUA_LIB_DIR)/api-gateway/tracking/validator/
2322

2423
test: redis
24+
echo "Starting redis server on default port"
25+
# $(BUILD_DIR)/redis-$(REDIS_VERSION)/src/redis-server test/resources/redis/redis-test.conf
26+
$(REDIS_SERVER) test/resources/redis/redis-test.conf
2527
echo "updating git submodules ..."
2628
if [ ! -d "test/resources/test-nginx/lib" ]; then git submodule update --init --recursive; fi
2729
echo "running tests ..."
@@ -30,13 +32,16 @@ test: redis
3032
cp -r test/resources/api-gateway $(BUILD_DIR)
3133
rm -f $(BUILD_DIR)/test-logs/*
3234

33-
PATH=/usr/local/sbin:$$PATH TEST_NGINX_SERVROOT=`pwd`/$(BUILD_DIR)/servroot TEST_NGINX_PORT=1989 prove -I ./test/resources/test-nginx/lib -I ./test/resources/test-nginx/inc -r ./test/perl
35+
PATH=/usr/local/sbin:$$PATH TEST_NGINX_SERVROOT=`pwd`/$(BUILD_DIR)/servroot TEST_NGINX_PORT=1989 prove -I ./test/resources/test-nginx/lib -I ./test/resources/test-nginx/inc -r ./test/perl
3436
cat $(BUILD_DIR)/redis-test.pid | xargs kill
3537

3638
redis: all
3739
mkdir -p $(BUILD_DIR)
38-
tar -xf test/resources/redis/redis-$(REDIS_VERSION).tar.gz -C $(BUILD_DIR)/
39-
cd $(BUILD_DIR)/redis-$(REDIS_VERSION) && make
40+
if [ "$(REDIS_SERVER)" = "$(BUILD_DIR)/redis-$(REDIS_VERSION)/src/redis-server" ]; then \
41+
tar -xf test/resources/redis/redis-$(REDIS_VERSION).tar.gz -C $(BUILD_DIR)/;\
42+
cd $(BUILD_DIR)/redis-$(REDIS_VERSION) && make; \
43+
fi
44+
echo " ... using REDIS_SERVER=$(REDIS_SERVER)"
4045

4146
.PHONY: pre-docker-test
4247
pre-docker-test:

0 commit comments

Comments
 (0)