Skip to content

Commit 374e121

Browse files
committed
py3 support for the Okta connector
This required: * Updating the supporting "okta" import to by fully py3-compatible. The sources are now at https://github.com/adobe-apiplatform/okta-sdk.py . * Updating one of the tests which was py2-specific in terms of string type and hash order.
1 parent 15d9571 commit 374e121

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed
-35.6 KB
Binary file not shown.
36 KB
Binary file not shown.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
packages=['user_sync', 'user_sync.connector'],
4747
install_requires=[
4848
'keyring',
49-
'okta==0.0.3',
49+
'okta==0.0.3.1',
5050
'psutil',
5151
'pycryptodome',
5252
'pyldap==2.4.37',

tests/connector/directory_okta_test.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,10 @@ class TestOKTAValueFormatter(unittest.TestCase):
3636
def test_get_extended_attribute_dict(self):
3737
"""Used to compare input and expected output data after OKTA formatting def Call"""
3838
attributes = ['firstName', 'lastName', 'login', 'email', 'countryCode']
39-
expectedresult = str("{'countryCode': <type 'str'>, 'lastName': <type 'str'>, 'login': <type 'str'>, 'email': <type 'str'>, 'firstName': <type 'str'>}")
39+
strtype = type('string')
40+
expectedresult = {'countryCode': strtype, 'lastName': strtype, 'login': strtype, 'email': strtype, 'firstName': strtype}
4041

41-
self.assertEqual(expectedresult, str(OKTAValueFormatter.get_extended_attribute_dict(attributes)), 'Getting expected Output')
42+
self.assertEqual(expectedresult, OKTAValueFormatter.get_extended_attribute_dict(attributes), 'Getting expected Output')
4243

4344

4445
class TestOktaErrors(unittest.TestCase):

0 commit comments

Comments
 (0)