Added TestCase for Bug issue #43 and Fixed create_test_user_uid() function

Author: bhunut-adobe

tests/connector/directory_okta_test.py

@@ -25,6 +25,7 @@
 import okta
 import json
 import tests.helper
+import copy
 
 from user_sync.error import AssertionException
 from user_sync.connector.directory_okta import OktaDirectoryConnector, \
@@ -156,7 +157,7 @@ def tearDown(self):
     def test_found_user_single_group(self, mock_members):
         # There are 1 users in the Group. This test should return 1 users.
         groups = ['group1']
-        test_user = tests.helper.create_test_user_uid(groups[0])
+        test_user = tests.helper.create_test_user_uid()
         mock_members.return_value = [test_user]
         directory = self.directory
         results = directory.load_users_and_groups(groups, [])
@@ -168,7 +169,7 @@ def test_found_user_multiple_groups(self, mock_members):
         groups = ['group1', 'group2']
         test_users = []
         for group in groups:
-            test_users.append([tests.helper.create_test_user_uid([group])])
+            test_users.append([tests.helper.create_test_user_uid()])
         mock_members.side_effect = test_users
         directory = self.directory
         results = directory.load_users_and_groups(groups, [])
@@ -181,7 +182,7 @@ def test_found_user_single_group_multiple_user(self, mock_members):
         test_users = []
         user_count = 0
         while user_count < 5:
-            test_users.append(tests.helper.create_test_user_uid(groups[0]))
+            test_users.append(tests.helper.create_test_user_uid())
             user_count = user_count + 1
         mock_members.return_value = test_users
         directory = self.directory
@@ -197,7 +198,7 @@ def test_found_user_multiple_groups_multiple_user(self, mock_members):
             test_users = []
             user_count = 0
             while user_count < 5:
-                test_users.append(tests.helper.create_test_user_uid(group))
+                test_users.append(tests.helper.create_test_user_uid())
                 user_count = user_count + 1
             total_test_users.append(test_users)
         mock_members.side_effect = total_test_users
@@ -225,7 +226,18 @@ def test_no_user_multiple_groups(self, mock_members):
         results = directory.load_users_and_groups(groups, [])
         self.assertEqual(len(list(results)), 0)
 
-# Used to Test UserGroupsClient , iter_group_members Definations
+    @mock.patch('user_sync.connector.directory_okta.OktaDirectoryConnector.iter_group_members')
+    def test_same_user_in_multiple_groups(self, mock_members):
+        # BUG User A suppose to be Group 1 and Group 2.
+        groups = ['group1', 'group2']
+        test_user = tests.helper.create_test_user_uid()
+        mock_members.side_effect = [[test_user], [copy.deepcopy(test_user)]]
+        directory = self.directory
+        result = directory.load_users_and_groups(groups, [])
+        result_list = list(result)
+        self.assertEqual(result_list[0]['groups'], ['group1','group2'])
+
+# Used to Test UserGroupsClient , iter_group_members Definitions
 class TestOktaIterGroupMember(unittest.TestCase):
     def setUp(self):
         class MockResponse:

tests/helper.py

@@ -51,7 +51,7 @@ def create_test_user(groups):
     }
     return user
 
-def create_test_user_uid(groups):
+def create_test_user_uid():
     global next_user_id
     firstName = 'User_%d' % next_user_id
     uid = '0000%s' % next_user_id
@@ -63,7 +63,7 @@ def create_test_user_uid(groups):
         'lastname': 'Test',
         'email': '%[email protected]' % firstName,
         'country': 'CA' if (next_user_id % 2 == 0) else 'US',
-        'groups': groups
+        'groups': []
     }
     return user