Fix all file IO related issues.

Rename FixFilename to ConvertToNativePath.
Add a new function ConvertToUnixPath for converting all selected files to unix path before returning them to JS layer.
Remove all calls to FixFilename since we're now using unix path and Windows file IO can handle unix path. Not sure we may still need it for  Win XP.
Append a '/' to the end of a directory before calling _wstat().

Author: RaymondLim

appshell/appshell_extensions_win.cpp

@@ -31,7 +31,8 @@
 #include <sys/stat.h>
 
 // Forward declarations for functions at the bottom of this file
-void FixFilename(ExtensionString& filename);
+void ConvertToNativePath(ExtensionString& filename);
+void ConvertToUnixPath(ExtensionString& filename);
 int ConvertErrnoCode(int errorCode, bool isReading = true);
 int ConvertWinErrorCode(int errorCode, bool isReading = true);
 
@@ -55,8 +56,6 @@ int32 ShowOpenDialog(bool allowMulitpleSelection,
     wchar_t szFile[MAX_PATH];
     szFile[0] = 0;
 
-    FixFilename(initialDirectory);
-
     // TODO (issue #64) - This method should be using IFileDialog instead of the
     /* outdated SHGetPathFromIDList and GetOpenFileName.
        
@@ -128,7 +127,9 @@ int32 ShowOpenDialog(bool allowMulitpleSelection,
                 // Check for two null terminators, which signal that only one file
                 // was selected
                 if (szFile[dir.length() + 1] == '\0') {
-                    selectedFiles->SetString(0, ExtensionString(dir));
+                    ExtensionString filePath(dir);
+                    ConvertToUnixPath(filePath);
+                    selectedFiles->SetString(0, filePath);
                 } else {
                     // Multiple files are selected
                     wchar_t fullPath[MAX_PATH];
@@ -142,8 +143,11 @@ int32 ShowOpenDialog(bool allowMulitpleSelection,
 
                         // The filename is relative to the directory that was specified as
                         // the first string
-                        if (PathCombine(fullPath, dir.c_str(), file.c_str()) != NULL)
-                            selectedFiles->SetString(fileIndex, ExtensionString(fullPath));
+                        if (PathCombine(fullPath, dir.c_str(), file.c_str()) != NULL) {
+                            ExtensionString filePath(fullPath);
+                            ConvertToUnixPath(filePath);
+                            selectedFiles->SetString(fileIndex, filePath);
+						}
 
                         // Go to the start of the next file name
                         i += file.length() + 1;
@@ -162,9 +166,10 @@ int32 ShowOpenDialog(bool allowMulitpleSelection,
 
 int32 ReadDir(ExtensionString path, CefRefPtr<CefListValue>& directoryContents)
 {
-    FixFilename(path);
+    if (path.length() && path[path.length() - 1] != '/')
+        path += '/';
 
-    path += L"\\*";
+    path += '*';
 
     WIN32_FIND_DATA ffd;
     HANDLE hFind = FindFirstFile(path.c_str(), &ffd);
@@ -205,8 +210,6 @@ int32 ReadDir(ExtensionString path, CefRefPtr<CefListValue>& directoryContents)
 
 int32 GetFileModificationTime(ExtensionString filename, uint32& modtime, bool& isDir)
 {
-    FixFilename(filename);
-
     DWORD dwAttr = GetFileAttributes(filename.c_str());
 
     if (dwAttr == INVALID_FILE_ATTRIBUTES) {
@@ -215,6 +218,11 @@ int32 GetFileModificationTime(ExtensionString filename, uint32& modtime, bool& i
 
     isDir = ((dwAttr & FILE_ATTRIBUTE_DIRECTORY) != 0);
 
+    // Remove trailing "/", if present. _wstat will fail with a "file not found"
+    // error if a directory has a trailing '/' in the name.
+    if (filename[filename.length() - 1] == '/')
+        filename[filename.length() - 1] = 0;
+
     struct _stat buffer;
     if(_wstat(filename.c_str(), &buffer) == -1) {
         return ConvertErrnoCode(errno); 
@@ -227,8 +235,6 @@ int32 GetFileModificationTime(ExtensionString filename, uint32& modtime, bool& i
 
 int32 ReadFile(ExtensionString filename, ExtensionString encoding, std::string& contents)
 {
-    FixFilename(filename);
-
     if (encoding != L"utf8")
         return ERR_UNSUPPORTED_ENCODING;
 
@@ -268,8 +274,6 @@ int32 ReadFile(ExtensionString filename, ExtensionString encoding, std::string&
 
 int32 WriteFile(ExtensionString filename, std::string contents, ExtensionString encoding)
 {
-    FixFilename(filename);
-
     if (encoding != L"utf8")
         return ERR_UNSUPPORTED_ENCODING;
 
@@ -292,8 +296,6 @@ int32 WriteFile(ExtensionString filename, std::string contents, ExtensionString
 
 int32 SetPosixPermissions(ExtensionString filename, int32 mode)
 {
-    FixFilename(filename);
-
     DWORD dwAttr = GetFileAttributes(filename.c_str());
 
     if (dwAttr == INVALID_FILE_ATTRIBUTES)
@@ -315,20 +317,24 @@ int32 SetPosixPermissions(ExtensionString filename, int32 mode)
 
 int32 DeleteFileOrDirectory(ExtensionString filename)
 {
-    FixFilename(filename);
-
     if (!DeleteFile(filename.c_str()))
         return ConvertWinErrorCode(GetLastError());
 
     return NO_ERROR;
 }
 
-void FixFilename(ExtensionString& filename)
+void ConvertToNativePath(ExtensionString& filename)
 {
     // Convert '/' to '\'
     replace(filename.begin(), filename.end(), '/', '\\');
 }
 
+void ConvertToUnixPath(ExtensionString& filename)
+{
+    // Convert '\\' to '/'
+    replace(filename.begin(), filename.end(), '\\', '/');
+}
+
 // Maps errors from errno.h to the brackets error codes
 // found in brackets_extensions.js
 int ConvertErrnoCode(int errorCode, bool isReading)