Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Commit 006967b

Browse files
author
Marcel Gerber
committed
Merge remote-tracking branch 'upstream/master' into unused-vars
Conflicts: src/widgets/StatusBar.js
2 parents 7c3c5c9 + bd219be commit 006967b

35 files changed

+1876
-161
lines changed

src/editor/EditorManager.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ define(function (require, exports, module) {
176176
* @param {!jQuery.Event} e - event
177177
* @param {?File} file - current file (can be null)
178178
*/
179-
function _handlecurrentFileChange(e, file) {
179+
function _handleCurrentFileChange(e, file) {
180180
var doc = file && DocumentManager.getOpenDocumentForPath(file.fullPath);
181181
_notifyActiveEditorChanged(doc && doc._masterEditor);
182182
}
@@ -473,7 +473,7 @@ define(function (require, exports, module) {
473473
*/
474474
function _createFullEditorForDocument(document, pane) {
475475
// Create editor; make it initially invisible
476-
var editor = _createEditorForDocument(document, true, pane.$el);
476+
var editor = _createEditorForDocument(document, true, pane.$content);
477477
editor.setVisible(false);
478478
pane.addView(editor);
479479
$(exports).triggerHandler("_fullEditorCreatedForDocument", [document, editor, pane.id]);
@@ -783,7 +783,7 @@ define(function (require, exports, module) {
783783
// Create PerfUtils measurement
784784
PerfUtils.createPerfMeasurement("JUMP_TO_DEFINITION", "Jump-To-Definiiton");
785785

786-
$(MainViewManager).on("currentFileChange", _handlecurrentFileChange);
786+
$(MainViewManager).on("currentFileChange", _handleCurrentFileChange);
787787
$(MainViewManager).on("workingSetRemove workingSetRemoveList", _handleRemoveFromPaneView);
788788

789789

src/editor/EditorStatusBar.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,10 +261,10 @@ define(function (require, exports, module) {
261261
}
262262

263263
if (!current) {
264-
StatusBar.hide();
264+
StatusBar.hideAllPanes();
265265
} else {
266266
var fullPath = current.document.file.fullPath;
267-
StatusBar.show();
267+
StatusBar.showAllPanes();
268268

269269
$(current).on("cursorActivity.statusbar", _updateCursorInfo);
270270
$(current).on("optionChange.statusbar", function () {
@@ -397,8 +397,6 @@ define(function (require, exports, module) {
397397
});
398398

399399
$statusOverwrite.on("click", _updateEditorOverwriteMode);
400-
401-
_onActiveEditorChange(null, EditorManager.getActiveEditor(), null);
402400
}
403401

404402
// Initialize: status bar focused listener
@@ -409,5 +407,7 @@ define(function (require, exports, module) {
409407
// Populate language switcher with all languages after startup; update it later if this set changes
410408
_populateLanguageDropdown();
411409
$(LanguageManager).on("languageAdded languageModified", _populateLanguageDropdown);
410+
_onActiveEditorChange(null, EditorManager.getActiveEditor(), null);
411+
StatusBar.show();
412412
});
413413
});

src/editor/ImageViewer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ define(function (require, exports, module) {
423423
if (view) {
424424
pane.showView(view);
425425
} else {
426-
view = new ImageView(file, pane.$el);
426+
view = new ImageView(file, pane.$content);
427427
pane.addView(view, true);
428428
}
429429
return new $.Deferred().resolve().promise();

src/htmlContent/pane.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
<div id="{{id}}" class="view-pane">
2-
<div class="not-editor"></div>
2+
<div class="pane-header"></div>
3+
<div class="pane-content">
4+
<div class="not-editor"></div>
5+
</div>
36
</div>

0 commit comments

Comments
 (0)