chore: Api audit (#7843)

* bring back UNSTABLE for TreeLoadingIndicator

* make status light children optional

* fix spelling

* only expose enterKeyHint through TextField and SearchField

* revert useTreeData additions

Author: snowystinger

packages/@react-aria/textfield/src/useTextField.ts

@@ -81,7 +81,11 @@ export interface AriaTextFieldOptions<T extends TextFieldIntrinsicElements> exte
    * Controls whether inputted text is automatically capitalized and, if so, in what manner.
    * See [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autocapitalize).
    */
-  autoCapitalize?: 'off' | 'none' | 'on' | 'sentences' | 'words' | 'characters'
+  autoCapitalize?: 'off' | 'none' | 'on' | 'sentences' | 'words' | 'characters',
+  /**
+   * An enumerated attribute that defines what action label or icon to preset for the enter key on virtual keyboards. See [https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/enterkeyhint].
+   */
+  enterKeyHint?: string
 }
 
 /**

packages/@react-spectrum/s2/src/Menu.tsx

@@ -72,7 +72,7 @@ export interface MenuTriggerProps extends AriaMenuTriggerProps {
   shouldFlip?: boolean
 }
 
-export interface MenuProps<T> extends Omit<AriaMenuProps<T>, 'children' | 'style' | 'className' | 'dependencies'>, StyleProps {
+export interface MenuProps<T> extends Omit<AriaMenuProps<T>, 'children' | 'style' | 'className' | 'dependencies' | 'renderEmptyState'>, StyleProps {
   /**
    * The size of the Menu.
    *

packages/@react-spectrum/s2/src/StatusLight.tsx

@@ -40,7 +40,7 @@ export interface StatusLightProps extends StatusLightStyleProps, DOMProps, AriaL
   /**
    * The content to display as the label.
    */
-  children: ReactNode,
+  children?: ReactNode,
   /**
    * An accessibility role for the status light. Should be set when the status
    * can change at runtime, and no more than one status light will update simultaneously.

packages/@react-stately/data/docs/useTreeData.mdx

@@ -182,33 +182,6 @@ tree.move('Sam', 'Animals', 1);
 tree.move('Sam', null, 1);
 ```
 
-### Move before
-An alias to move
-
-```tsx
-// Move an item within the same parent
-tree.moveBefore('Sam', 'People', 0);
-
-// Move an item to a different parent
-tree.moveBefore('Sam', 'Animals', 1);
-
-// Move an item to the root
-tree.moveBefore('Sam', null, 1);
-```
-
-### Move after
-
-```tsx
-// Move an item within the same parent
-tree.moveAfter('Sam', 'People', 0);
-
-// Move an item to a different parent
-tree.moveAfter('Sam', 'Animals', 1);
-
-// Move an item to the root
-tree.moveAfter('Sam', null, 1);
-```
-
 ### Updating items
 
 ```tsx

packages/@react-stately/data/src/useTreeData.ts

@@ -107,22 +107,6 @@ export interface TreeData<T extends object> {
    */
   move(key: Key, toParentKey: Key | null, index: number): void,
 
-  /**
-   * Moves an item before a node within the tree.
-   * @param key - The key of the item to move.
-   * @param toParentKey - The key of the new parent to insert into. `null` for the root.
-   * @param index - The index within the new parent to insert before.
-   */
-  moveBefore(key: Key, toParentKey: Key | null, index: number): void,
-
-  /**
-   * Moves an item after a node within the tree.
-   * @param key - The key of the item to move.
-   * @param toParentKey - The key of the new parent to insert into. `null` for the root.
-   * @param index - The index within the new parent to insert after.
-   */
-  moveAfter(key: Key, toParentKey: Key | null, index: number): void,
-
   /**
    * Updates an item in the tree.
    * @param key - The key of the item to update.
@@ -389,50 +373,6 @@ export function useTreeData<T extends object>(options: TreeOptions<T>): TreeData
         }), newMap);
       });
     },
-    moveBefore(key: Key, toParentKey: Key | null, index: number) {
-      this.move(key, toParentKey, index);
-    },
-    moveAfter(key: Key, toParentKey: Key | null, index: number) {
-      setItems(({items, nodeMap: originalMap}) => {
-        let node = originalMap.get(key);
-        if (!node) {
-          return {items, nodeMap: originalMap};
-        }
-
-        let {items: newItems, nodeMap: newMap} = updateTree(items, key, () => null, originalMap);
-
-        const movedNode = {
-          ...node,
-          parentKey: toParentKey
-        };
-
-        const afterIndex = items.length === index ? index : index + 1;
-        // If parentKey is null, insert into the root.
-        if (toParentKey == null) {
-          newMap.set(movedNode.key, movedNode);
-          return {items: [
-            ...newItems.slice(0, afterIndex),
-            movedNode,
-            ...newItems.slice(afterIndex)
-          ], nodeMap: newMap};
-        }
-
-        // Otherwise, update the parent node and its ancestors.
-        return updateTree(newItems, toParentKey, parentNode => {
-          const c = [
-            ...parentNode.children!.slice(0, afterIndex),
-            movedNode,
-            ...parentNode.children!.slice(afterIndex)
-          ];
-          return {
-            key: parentNode.key,
-            parentKey: parentNode.parentKey,
-            value: parentNode.value,
-            children: c
-          };
-        }, newMap);
-      });
-    },
     update(oldKey: Key, newValue: T) {
       setItems(({items, nodeMap: originalMap}) => updateTree(items, oldKey, oldNode => {
         let node: TreeNode<T> = {

packages/@react-stately/data/test/useTreeData.test.js

@@ -685,7 +685,7 @@ describe('useTreeData', function () {
       useTreeData({initialItems, getChildren, getKey})
     );
     act(() => {
-      result.current.moveBefore('Eli', null, 0);
+      result.current.move('Eli', null, 0);
     });
     expect(result.current.items[0].key).toEqual('Eli');
     expect(result.current.items[1].key).toEqual('David');
@@ -700,7 +700,7 @@ describe('useTreeData', function () {
       useTreeData({initialItems, getChildren, getKey})
     );
     act(() => {
-      result.current.moveBefore('Eli', 'David', 1);
+      result.current.move('Eli', 'David', 1);
     });
     expect(result.current.items[0].key).toEqual('David');
     expect(result.current.items[0].children[0].key).toEqual('John');
@@ -716,7 +716,7 @@ describe('useTreeData', function () {
     );
 
     act(() => {
-      result.current.moveAfter('Eli', 'David', 1);
+      result.current.move('Eli', 'David', 2);
     });
     expect(result.current.items[0].key).toEqual('David');
 
@@ -734,7 +734,7 @@ describe('useTreeData', function () {
     );
 
     act(() => {
-      result.current.moveAfter('Eli', 'David', 100);
+      result.current.move('Eli', 'David', 101);
     });
     expect(result.current.items[0].key).toEqual('David');
 

packages/@react-types/searchfield/src/index.d.ts

@@ -21,5 +21,10 @@ export interface SearchFieldProps extends TextFieldProps {
   onClear?: () => void
 }
 
-export interface AriaSearchFieldProps extends SearchFieldProps, AriaTextFieldProps {}
+export interface AriaSearchFieldProps extends SearchFieldProps, AriaTextFieldProps {
+  /**
+   * An enumerated attribute that defines what action label or icon to preset for the enter key on virtual keyboards. See [https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/enterkeyhint].
+   */
+  enterKeyHint?: string
+}
 export interface SpectrumSearchFieldProps extends SpectrumTextInputBase, Omit<AriaSearchFieldProps, 'isInvalid' | 'validationState'>, SpectrumTextFieldProps {}

packages/@react-types/shared/src/dom.d.ts

@@ -176,12 +176,7 @@ export interface TextInputDOMProps extends DOMProps, InputDOMProps, TextInputDOM
   /**
    * An enumerated attribute that defines whether the element may be checked for spelling errors. See [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck).
    */
-  spellCheck?: string,
-
-  /**
-   * An enumerated attribute that defines what action label or icon to preset for the enter key on virtual keyboards. See [https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/enterkeyhint].
-   */
-  enterKeyHint?: string
+  spellCheck?: string
 }
 
 /**

packages/@react-types/textfield/src/index.d.ts

@@ -44,7 +44,12 @@ export interface AriaTextFieldProps<T = HTMLInputElement> extends TextFieldProps
   /** Indicates the availability and type of interactive popup element, such as menu or dialog, that can be triggered by an element. */
   'aria-haspopup'?: boolean | 'false' | 'true' | 'menu' | 'listbox' | 'tree' | 'grid' | 'dialog',
   /** Identifies the element (or elements) whose contents or presence are controlled by the current element. */
-  'aria-controls'?: string
+  'aria-controls'?: string,
+  /**
+   * An enumerated attribute that defines what action label or icon to preset for the enter key on virtual keyboards. See [https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/enterkeyhint].
+   */
+  enterKeyHint?: string
+
 }
 
 interface SpectrumTextFieldBaseProps {

packages/react-aria-components/src/Table.tsx

@@ -988,12 +988,12 @@ export const TableBody = /*#__PURE__*/ createBranchComponent('tablebody', <T ext
 
 export interface RowRenderProps extends ItemRenderProps {
   /** Whether the row's children have keyboard focus. */
-  isFocusVisibleWithin: boolean
+  isFocusVisibleWithin: boolean,
+  /** The unique id of the row. */
+  id?: Key
 }
 
 export interface RowProps<T> extends StyleRenderProps<RowRenderProps>, LinkDOMProps, HoverEvents {
-  /** The unique id of the row. */
-  id?: Key,
   /** A list of columns used when dynamically rendering cells. */
   columns?: Iterable<T>,
   /** The cells within the row. Supports static items or a function for dynamic rendering. */
@@ -1010,7 +1010,9 @@ export interface RowProps<T> extends StyleRenderProps<RowRenderProps>, LinkDOMPr
    * Handler that is called when a user performs an action on the row. The exact user event depends on
    * the collection's `selectionBehavior` prop and the interaction modality.
    */
-  onAction?: () => void
+  onAction?: () => void,
+  /** The unique id of the row. */
+  id?: Key
 }
 
 /**
@@ -1087,7 +1089,8 @@ export const Row = /*#__PURE__*/ createBranchComponent(
         selectionBehavior: state.selectionManager.selectionBehavior,
         isDragging,
         isDropTarget: dropIndicator?.isDropTarget,
-        isFocusVisibleWithin
+        isFocusVisibleWithin,
+        id: item.key
       }
     });
 
@@ -1178,12 +1181,14 @@ export interface CellRenderProps {
    * Whether the cell is currently hovered with a mouse.
    * @selector [data-hovered]
    */
-  isHovered: boolean
+  isHovered: boolean,
+  /**
+   * The unique id of the cell.
+   **/
+  id?: Key
 }
 
 export interface CellProps extends RenderProps<CellRenderProps> {
-  /** The unique id of the cell. */
-  id?: Key,
   /** A string representation of the cell's contents, used for features like typeahead. */
   textValue?: string,
   /** Indicates how many columns the data cell spans. */
@@ -1217,7 +1222,8 @@ export const Cell = /*#__PURE__*/ createLeafComponent('cell', (props: CellProps,
       isFocused,
       isFocusVisible,
       isPressed,
-      isHovered
+      isHovered,
+      id: cell.key
     }
   });