Skip to content

Commit 3372bd9

Browse files
fix: remove application of hover/focus/active states if disabled
Adds a :not(.is-disabled) selector for hover/focus/active states to ensure that those styles do not apply for disabled accordion item headers. In many cases this is not necessary, but when a --mod is used for hover/ focus/active colors, the mod was still being applied even when the disabled class was present.
1 parent 8b1aeba commit 3372bd9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

components/accordion/index.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,20 +297,20 @@
297297
color: var(--mod-accordion-item-header-color-default, var(--spectrum-accordion-item-header-color-default));
298298
background-color: var(--mod-accordion-background-color-default, var(--spectrum-accordion-background-color-default));
299299

300-
&:hover {
300+
&:hover &:not(.is-disabled) {
301301
color: var(--mod-accordion-item-header-color-hover, var(--spectrum-accordion-item-header-color-hover));
302302
background-color: var(--mod-accordion-background-color-hover, var(--spectrum-accordion-background-color-hover));
303303
}
304304

305-
&:focus-visible {
305+
&:focus-visible &:not(.is-disabled) {
306306
border-radius: var(--mod-accordion-corner-radius, var(--spectrum-accordion-corner-radius));
307307
background-color: var(--mod-accordion-background-color-key-focus, var(--spectrum-accordion-background-color-key-focus));
308308
color: var(--mod-accordion-item-header-color-key-focus, var(--spectrum-accordion-item-header-color-key-focus));
309309
outline: var(--mod-accordion-focus-indicator-thickness, var(--spectrum-accordion-focus-indicator-thickness)) solid var(--mod-accordion-focus-indicator-color, var(--spectrum-accordion-focus-indicator-color));
310310
outline-offset: var(--mod-accordion-focus-indicator-gap, var(--spectrum-accordion-focus-indicator-gap));
311311
}
312312

313-
&:active {
313+
&:active &:not(.is-disabled) {
314314
background-color: var(--mod-accordion-background-color-down, var(--spectrum-accordion-background-color-down));
315315
color: var(--mod-accordion-item-header-color-down, var(--spectrum-accordion-item-header-color-down));
316316
}

0 commit comments

Comments
 (0)