MongoDb: Add index used when querying for all events for an aggregate type #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason:
The index is needed when using this api call:
store.getEvents({aggregate:'my-aggregate', skip, limit, cb)
(the values of skip and limit don't matter)
The query above is handled by this call to mongodb client:
this.events.find(findStatement, { sort: [
['commitStamp', 'asc'],
['streamRevision', 'asc'],
['commitSequence', 'asc']] }).toArray(function (err, res) {
https://github.com/adrai/node-eventstore/blob/v1.7.3/lib/databases/mongodb.js#L327
Without the index, MongoDb has to sort in memory, which works fine for
few events, but with enough events you'll hit the ceiling and get this
error:
> Plan executor error during find: Overflow sort stage buffered data
> usage of 33554808 bytes exceeds internal limit of 33554432 bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
The index is needed when using this api call:
(the values of skip and limit don't matter)
The query above is handled by this call to mongodb client:
https://github.com/adrai/node-eventstore/blob/v1.7.3/lib/databases/mongodb.js#L327
Without the index, MongoDb has to sort in memory, which works fine for few events, but with enough events you'll hit the ceiling and get an error, like this: