Skip to content

Commit 18efcc1

Browse files
committed
5.3.0
1 parent 7aec825 commit 18efcc1

File tree

5 files changed

+34
-398
lines changed

5 files changed

+34
-398
lines changed

README.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,15 @@ More information about grpc_tools_node_protoc (grpc-tools):
2828
And the versions over 3.0.0 support [@grpc/grpc-js](https://www.npmjs.com/package/@grpc/grpc-js)([email protected] required). Please read the doc: [@grpc/grpc-js support](https://github.com/agreatfool/grpc_tools_node_protoc_ts/blob/v5.0.0/doc/grpcjs_support.md). **New version 5.0.0 is recommended for users who using grpc-tools over v1.9.0.**
2929

3030
## Breaking changes
31+
### v5.3.0
32+
Since `@grpc/[email protected]` fixed the signature issue of `handleClientStreamingCall` exporting. It's no longer necessary to import it manually in `*_pb.d.ts` files like:
33+
34+
```typescript
35+
import {handleClientStreamingCall} from "@grpc/grpc-js/build/src/server-call";
36+
```
37+
38+
Users who are using versions lower than `@grpc/[email protected]` would be impacted, need to upgrade.
39+
3140
### v5.2.0
3241
Add support for proto3 `optional`. `grpc-tools` version of `1.11.1` is `REQUIRED`. See: [Issue#88](https://github.com/agreatfool/grpc_tools_node_protoc_ts/issues/88) and [PR#97](https://github.com/agreatfool/grpc_tools_node_protoc_ts/pull/97).
3342

@@ -638,6 +647,17 @@ export class BookServiceClient extends grpc.Client implements IBookServiceClient
638647
```
639648

640649
## Changes
650+
### 5.3.0
651+
Fix signature issue of `handleClientStreamingCall` exporting. See [PR#105](https://github.com/agreatfool/grpc_tools_node_protoc_ts/pull/105).
652+
653+
Since `@grpc/[email protected]` fixed the signature issue of `handleClientStreamingCall` exporting. It's no longer necessary to import it manually in `*_pb.d.ts` files like:
654+
655+
```typescript
656+
import {handleClientStreamingCall} from "@grpc/grpc-js/build/src/server-call";
657+
```
658+
659+
Users who are using versions lower than `@grpc/[email protected]` would be impacted, need to upgrade.
660+
641661
### 5.2.2
642662
Fix vulnerabilities. See: [PR#102](https://github.com/agreatfool/grpc_tools_node_protoc_ts/pull/102).
643663

build/lib/format/ProtoSvcTsdFormatter.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

build/lib/template/svc_tsd.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export interface I{{{serviceName}}}Server{{#if (fetchIsGrpcJs)}} extends grpc.Un
3636
{{/eq}}
3737
{{#eq type "ClientWritableStream"}}
3838
{{#if (fetchIsGrpcJs)}}
39-
{{lcFirst methodName}}: handleClientStreamingCall<{{{requestTypeName}}}, {{{responseTypeName}}}>;
39+
{{lcFirst methodName}}: grpc.handleClientStreamingCall<{{{requestTypeName}}}, {{{responseTypeName}}}>;
4040
{{else}}
4141
{{lcFirst methodName}}: grpc.handleClientStreamingCall<{{{requestTypeName}}}, {{{responseTypeName}}}>;
4242
{{/if}}

0 commit comments

Comments
 (0)