Skip to content

Commit 141ef78

Browse files
authored
Merge pull request #48 from ahuang11/fix_validation
Do not raise if custom renderer
2 parents 92d2c5e + ffdbada commit 141ef78

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

streamjoy/_utils.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,7 @@ def validate_xarray(
249249
dim: str | None = None,
250250
var: str | None = None,
251251
warn: bool = True,
252+
raise_ndim: bool = True,
252253
):
253254
import xarray as xr
254255

@@ -262,7 +263,7 @@ def validate_xarray(
262263

263264
squeeze_dims = [d for d in ds.dims if d != dim and ds.sizes[d] == 1]
264265
ds = ds.squeeze(squeeze_dims)
265-
if ds.ndim > 3:
266+
if ds.ndim > 3 and raise_ndim:
266267
raise ValueError(f"Can only handle 3D arrays; {ds.ndim}D array found")
267268
return ds
268269

streamjoy/serializers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def serialize_xarray(
119119
dim = kwargs.pop("dim", None)
120120
var = kwargs.pop("var", None)
121121

122-
ds = _utils.validate_xarray(ds, dim=dim, var=var)
122+
ds = _utils.validate_xarray(ds, dim=dim, var=var, raise_ndim=renderer is None)
123123
if not dim:
124124
dim = list(ds.dims)[0]
125125
_utils.warn_default_used("dim", dim, suffix="from the dataset")

0 commit comments

Comments
 (0)