Add option to control video quality

[zhihua-zheng]

Hi,

This is a great package! As of now, I don't see an option to let user set the quality of video. Is it possible to do so?
I think this thread may be helpful: imageio/imageio#1062

[ahuang11]

I'm glad you like it!

If I'm not mistaken, you can set write_kwargs to modify write_frame()
https://github.com/ahuang11/streamjoy/blob/main/streamjoy/streams.py#L765

https://github.com/ahuang11/streamjoy/blob/main/streamjoy/streams.py#L85-L88

Let me know if that helps!

[ahuang11]

Hmm, I'm hesitant to touch internal variables like that.

Can you check if this works?

with iio.imopen(temp_output, "w", plugin="pyav", options={'crf': '18'}) as writer:
    writer.init_video_stream("libx264", fps=fps)
    ...
    writer.write(batch)

If so, I can add imopen_kwargs
https://github.com/ahuang11/streamjoy/blob/main/streamjoy/streams.py#L1101

[zhihua-zheng]

This doesn't work. As others have reported, I get Some options were not used: {'crf': '18'}

[ahuang11]

I see. Would you be interested in putting a pull request?

I think a minor change like this:

if "crf" in write_kwargs:
    buf._video_stream.options = {'crf': str(write_kwargs.pop("crf"))}

https://github.com/ahuang11/streamjoy/blob/main/streamjoy/streams.py#L784-L785

https://github.com/ahuang11/streamjoy/blob/main/HOWTOCONTRIBUTE.md

[zhihua-zheng]

Yes, I will give it a try later today!

[ahuang11]

It's now available in v0.0.8