Repository navigation
refactor(llm): preserve typed aggregation errors - #12807
Merged
Merged
Conversation
rmccorm4
marked this pull request as ready for review
August 7, 2026 07:19
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (12)
WalkthroughThe change standardizes annotated-stream aggregation on ChangesTyped stream error propagation
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
|
🎯 Code Coverage (details) 🔗 Commit SHA: 5d3e4dc | Docs | Datadog PR Page | Give us feedback! |
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
rmccorm4
force-pushed
the
rmccormick/unify-errors-typed-aggregation
branch
from
August 7, 2026 17:50
e397bee to
5d3e4dc
Compare
KrishnanPrash
approved these changes
Aug 7, 2026
Contributor
Author
|
This PR stack likely covers the same fix or majority of fix that #12832 is targeting |
rmccorm4
commented
Aug 7, 2026
GuanLuo
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
1 of 4 — base:
mainNext: #12808
Summary
DynamoErrorvalues when consumingAnnotated<T>.This layer intentionally does not change HTTP status policy.
Root cause
Unary aggregators converted annotated backend errors to strings. Once the structured error type was discarded, the HTTP layer could not reliably distinguish invalid client input from runtime failures.
Validation
cargo check -p dynamo-llm: passedcargo fmt --all -- --check: passedgit diff --check: passedTracking
Summary by CodeRabbit