Skip to content

Conversation

@Eiffel-Alpine
Copy link

No description provided.

@xmik
Copy link
Member

xmik commented Mar 12, 2019

So, from your PR, the only difference between linux and darwin shell is one line, on linux:

const ioctlReadTermios = syscall.TCGETS

and on darwin:

const ioctlReadTermios = syscall.TIOCGETA

Is this PR a WIP or do you wanted to just show me the tested version that works on osx?

@Eiffel-Alpine
Copy link
Author

yes that is the only difference. it is up to you what to do. i tested the change and it works.

@xmik
Copy link
Member

xmik commented Apr 22, 2019

@Eiffel-Alpine, I incorporated your changes and added you to changelog https://github.com/ai-traders/dojo/releases/tag/0.3.2. From now on, Dojo will be cross compiled and there will be two binaries released: one for Linux and one for Darwin.

@xmik xmik closed this Apr 22, 2019
tomzo added a commit to tomzo/dojo that referenced this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants