Skip to content

change threshold lines to geom_vline / geom_hline #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxheld83 opened this issue Aug 16, 2015 · 0 comments
Closed

change threshold lines to geom_vline / geom_hline #220

maxheld83 opened this issue Aug 16, 2015 · 0 comments
Labels
enhancement nfactors plots
Milestone
Backlog

Comments

@maxheld83
Copy link
Collaborator

#157 was solved by a hack job, which leaves something to be desired: line does not extend all the way through the y-height of the plot, as one would like.

Might be because of this bug: tidyverse/ggplot2#1267

This is acceptable for now, but would be nice to resolve at some point:

rplot02
@maxheld83 maxheld83 added this to the Backlog milestone Aug 16, 2015
@maxheld83 maxheld83 changed the title improve geom_v/hline labels in q.nfactors and others change threshold lines to geom_vline / geom_hline Aug 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement nfactors plots
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@maxheld83 @aiorazabala