Skip to content

Commit 0e11c22

Browse files
author
spalger
committed
[aggConfig] add light validation for aggConfig field param
1 parent 95d704c commit 0e11c22

File tree

1 file changed

+8
-1
lines changed
  • src/ui/public/agg_types/param_types

1 file changed

+8
-1
lines changed

src/ui/public/agg_types/param_types/field.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ import editorHtml from 'ui/agg_types/controls/field.html';
44
import AggTypesParamTypesBaseProvider from 'ui/agg_types/param_types/base';
55
import 'ui/filters/field_type';
66
import IndexedArray from 'ui/indexed_array';
7+
import Notifier from 'ui/notify/notifier';
78

89
export default function FieldAggParamFactory(Private, $filter) {
910
let BaseAggParam = Private(AggTypesParamTypesBaseProvider);
11+
const notifier = new Notifier();
1012

1113
_.class(FieldAggParam).inherits(BaseAggParam);
1214
function FieldAggParam(config) {
@@ -67,7 +69,12 @@ export default function FieldAggParamFactory(Private, $filter) {
6769
throw new SavedObjectNotFound('index-pattern-field', fieldName);
6870
}
6971

70-
return field;
72+
const validField = this.getFieldOptions(aggConfig).byName[fieldName];
73+
if (!validField) {
74+
notifier.error(`"field" is invalid`);
75+
}
76+
77+
return validField;
7178
};
7279

7380
/**

0 commit comments

Comments
 (0)