Skip to content

Commit 6cc9309

Browse files
bump: grpc-core, grpc-interop-testing, ... 1.70.0 (was 1.63.2) (#2011)
Additional changes required * Skip module-info in assemblies (present in multiple dependencies) * Changes to interop tests because of upstream changes. --------- Co-authored-by: Johan Andrén <johan@markatta.com>
1 parent 8222347 commit 6cc9309

File tree

11 files changed

+17
-120
lines changed

11 files changed

+17
-120
lines changed

benchmark-java/build.sbt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ run / javaOptions ++= List("-Xms1g", "-Xmx1g", "-XX:+PrintGCDetails", "-XX:+Prin
99
// generate both client and server (default) in Java
1010
akkaGrpcGeneratedLanguages := Seq(AkkaGrpc.Java)
1111

12-
val grpcVersion = "1.63.2" // checked synced by VersionSyncCheckPlugin
12+
val grpcVersion = "1.70.0" // checked synced by VersionSyncCheckPlugin
1313

1414
val runtimeProject = ProjectRef(file("../"), "akka-grpc-runtime")
1515

build.sbt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,14 @@ ThisBuild / dynverSeparator := "-"
1616
// append -SNAPSHOT to version when isSnapshot
1717
ThisBuild / dynverSonatypeSnapshots := true
1818

19+
// skip Java 9 module info in all assembled artifacts
20+
ThisBuild / assemblyMergeStrategy := {
21+
case x if x.endsWith("module-info.class") => MergeStrategy.discard
22+
case x =>
23+
val oldStrategy = (ThisBuild / assemblyMergeStrategy).value
24+
oldStrategy(x)
25+
}
26+
1927
val akkaGrpcCodegenId = "akka-grpc-codegen"
2028
lazy val codegen = Project(id = akkaGrpcCodegenId, base = file("codegen"))
2129
.enablePlugins(SbtTwirl, BuildInfoPlugin)

gradle-plugin/src/main/groovy/akka/grpc/gradle/AkkaGrpcPluginExtension.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class AkkaGrpcPluginExtension {
99

1010
static final String PROTOC_PLUGIN_SCALA_VERSION = "2.12"
1111

12-
static final String GRPC_VERSION = "1.63.2" // checked synced by VersionSyncCheckPlugin
12+
static final String GRPC_VERSION = "1.70.0" // checked synced by VersionSyncCheckPlugin
1313

1414
static final String PLUGIN_CODE = 'com.lightbend.akka.grpc.gradle'
1515

interop-tests/src/main/java/io/grpc/testing/integration2/ClientTester.java

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010

1111
/**
1212
* This class has all the methods of the grpc-java AbstractInteropTest, but none of the implementations,
13-
* so it can implemented either by calling AbstractInteropTest or with an Akka gRPC implementation.
13+
* so it can implement either by calling AbstractInteropTest or with an Akka gRPC implementation.
14+
* https://github.com/grpc/grpc-java/blob/master/interop-testing/src/main/java/io/grpc/testing/integration/AbstractInteropTest.java
1415
*
1516
* Test requirements documentation: https://github.com/grpc/grpc/blob/master/doc/interop-test-descriptions.md
1617
*/
@@ -22,8 +23,6 @@ public interface ClientTester {
2223

2324
void emptyUnary() throws Exception;
2425

25-
void cacheableUnary();
26-
2726
void largeUnary() throws Exception;
2827

2928
void clientCompressedUnary(boolean probe) throws Exception;
@@ -42,16 +41,6 @@ public interface ClientTester {
4241

4342
void emptyStream() throws Exception;
4443

45-
void computeEngineCreds(String serviceAccount, String oauthScope) throws Exception;
46-
47-
void serviceAccountCreds(String jsonKey, InputStream credentialsStream, String authScope) throws Exception;
48-
49-
void jwtTokenCreds(InputStream serviceAccountJson) throws Exception;
50-
51-
void oauth2AuthToken(String jsonKey, InputStream credentialsStream, String authScope) throws Exception;
52-
53-
void perRpcCreds(String jsonKey, InputStream credentialsStream, String oauthScope) throws Exception;
54-
5544
void customMetadata() throws Exception;
5645

5746
void statusCodeAndMessage() throws Exception;

interop-tests/src/main/java/io/grpc/testing/integration2/GrpcJavaClientTester.java

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,9 @@
44

55
package io.grpc.testing.integration2;
66

7-
import io.grpc.ManagedChannel;
87
import io.grpc.ManagedChannelBuilder;
98
import io.grpc.testing.integration.AbstractInteropTest;
109

11-
import java.io.InputStream;
12-
1310
/**
1411
* Implementation of ClientTester that forwards all calls to the
1512
* grpc-java AbstractInteropTest.
@@ -41,11 +38,6 @@ public void emptyUnary() throws Exception {
4138
tester.emptyUnary();
4239
}
4340

44-
@Override
45-
public void cacheableUnary() {
46-
tester.cacheableUnary();
47-
}
48-
4941
@Override
5042
public void largeUnary() throws Exception {
5143
tester.largeUnary();
@@ -91,31 +83,6 @@ public void emptyStream() throws Exception {
9183
tester.emptyStream();
9284
}
9385

94-
@Override
95-
public void computeEngineCreds(String serviceAccount, String oauthScope) throws Exception {
96-
tester.computeEngineCreds(serviceAccount, oauthScope);
97-
}
98-
99-
@Override
100-
public void serviceAccountCreds(String jsonKey, InputStream credentialsStream, String authScope) throws Exception {
101-
tester.serviceAccountCreds(jsonKey, credentialsStream, authScope);
102-
}
103-
104-
@Override
105-
public void jwtTokenCreds(InputStream serviceAccountJson) throws Exception {
106-
tester.jwtTokenCreds(serviceAccountJson);
107-
}
108-
109-
@Override
110-
public void oauth2AuthToken(String jsonKey, InputStream credentialsStream, String authScope) throws Exception {
111-
tester.oauth2AuthToken(jsonKey, credentialsStream, authScope);
112-
}
113-
114-
@Override
115-
public void perRpcCreds(String jsonKey, InputStream credentialsStream, String oauthScope) throws Exception {
116-
tester.perRpcCreds(jsonKey, credentialsStream, oauthScope);
117-
}
118-
11986
@Override
12087
public void customMetadata() throws Exception {
12188
tester.customMetadata();
@@ -151,7 +118,7 @@ public void timeoutOnSleepingServer() throws Exception {
151118
tester.timeoutOnSleepingServer();
152119
}
153120

154-
private class UnderlyingTester extends AbstractInteropTest {
121+
public final class UnderlyingTester extends AbstractInteropTest {
155122
@Override
156123
protected ManagedChannelBuilder<?> createChannelBuilder() {
157124
return ChannelBuilder.create(settings);

interop-tests/src/main/java/io/grpc/testing/integration2/TestServiceClient.java

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,6 @@ private void runTest(TestCases testCase, Settings settings) throws Exception {
105105
clientTester.emptyUnary();
106106
break;
107107

108-
case CACHEABLE_UNARY: {
109-
clientTester.cacheableUnary();
110-
break;
111-
}
112-
113108
case LARGE_UNARY:
114109
clientTester.largeUnary();
115110
break;
@@ -146,37 +141,6 @@ private void runTest(TestCases testCase, Settings settings) throws Exception {
146141
clientTester.emptyStream();
147142
break;
148143

149-
case COMPUTE_ENGINE_CREDS:
150-
clientTester.computeEngineCreds(settings.getDefaultServiceAccount(), settings.getOauthScope());
151-
break;
152-
153-
case SERVICE_ACCOUNT_CREDS: {
154-
String jsonKey = Files.asCharSource(new File(settings.getServiceAccountKeyFile()), UTF_8).read();
155-
FileInputStream credentialsStream = new FileInputStream(new File(settings.getServiceAccountKeyFile()));
156-
clientTester.serviceAccountCreds(jsonKey, credentialsStream, settings.getOauthScope());
157-
break;
158-
}
159-
160-
case JWT_TOKEN_CREDS: {
161-
FileInputStream credentialsStream = new FileInputStream(new File(settings.getServiceAccountKeyFile()));
162-
clientTester.jwtTokenCreds(credentialsStream);
163-
break;
164-
}
165-
166-
case OAUTH2_AUTH_TOKEN: {
167-
String jsonKey = Files.asCharSource(new File(settings.getServiceAccountKeyFile()), UTF_8).read();
168-
FileInputStream credentialsStream = new FileInputStream(new File(settings.getServiceAccountKeyFile()));
169-
clientTester.oauth2AuthToken(jsonKey, credentialsStream, settings.getOauthScope());
170-
break;
171-
}
172-
173-
case PER_RPC_CREDS: {
174-
String jsonKey = Files.asCharSource(new File(settings.getServiceAccountKeyFile()), UTF_8).read();
175-
FileInputStream credentialsStream = new FileInputStream(new File(settings.getServiceAccountKeyFile()));
176-
clientTester.perRpcCreds(jsonKey, credentialsStream, settings.getOauthScope());
177-
break;
178-
}
179-
180144
case CUSTOM_METADATA: {
181145
clientTester.customMetadata();
182146
break;

interop-tests/src/test/java/akka/grpc/interop/AkkaGrpcJavaClientTester.java

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import org.junit.Assert;
2929
import scala.concurrent.ExecutionContext;
3030

31-
import java.io.InputStream;
3231
import java.util.ArrayList;
3332
import java.util.List;
3433
import java.util.Optional;
@@ -86,11 +85,6 @@ public void emptyUnary() throws Exception {
8685
);
8786
}
8887

89-
@Override
90-
public void cacheableUnary() {
91-
throw new UnsupportedOperationException("Not implemented!");
92-
}
93-
9488
@Override
9589
public void largeUnary() throws Exception {
9690
final Messages.SimpleRequest request = Messages.SimpleRequest.newBuilder()
@@ -248,31 +242,6 @@ public void emptyStream() throws Exception {
248242
assertEquals(0, response.size());
249243
}
250244

251-
@Override
252-
public void computeEngineCreds(String serviceAccount, String oauthScope) throws Exception {
253-
throw new UnsupportedOperationException("Not implemented!");
254-
}
255-
256-
@Override
257-
public void serviceAccountCreds(String jsonKey, InputStream credentialsStream, String authScope) throws Exception {
258-
throw new UnsupportedOperationException("Not implemented!");
259-
}
260-
261-
@Override
262-
public void jwtTokenCreds(InputStream serviceAccountJson) throws Exception {
263-
throw new UnsupportedOperationException("Not implemented!");
264-
}
265-
266-
@Override
267-
public void oauth2AuthToken(String jsonKey, InputStream credentialsStream, String authScope) throws Exception {
268-
throw new UnsupportedOperationException("Not implemented!");
269-
}
270-
271-
@Override
272-
public void perRpcCreds(String jsonKey, InputStream credentialsStream, String oauthScope) throws Exception {
273-
throw new UnsupportedOperationException("Not implemented!");
274-
}
275-
276245
@Override
277246
public void customMetadata() throws Exception {
278247
// unary call

plugin-tester-java/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<maven-exec-plugin.version>3.0.0</maven-exec-plugin.version>
1717
<akka.http.cors.version>1.1.0</akka.http.cors.version>
1818
<akka.version>2.10.0</akka.version>
19-
<grpc.version>1.63.2</grpc.version> <!-- checked synced by VersionSyncCheckPlugin -->
19+
<grpc.version>1.70.0</grpc.version> <!-- checked synced by VersionSyncCheckPlugin -->
2020
<project.encoding>UTF-8</project.encoding>
2121
<build-helper-maven-plugin>3.3.0</build-helper-maven-plugin>
2222
<protobuf-java.version>3.22.2</protobuf-java.version>

plugin-tester-scala/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<maven.compiler.release>11</maven.compiler.release>
1515
<akka.version>2.10.0</akka.version>
1616
<akka.http.cors.version>0.4.2</akka.http.cors.version>
17-
<grpc.version>1.63.2</grpc.version> <!-- checked synced by VersionSyncCheckPlugin -->
17+
<grpc.version>1.70.0</grpc.version> <!-- checked synced by VersionSyncCheckPlugin -->
1818
<project.encoding>UTF-8</project.encoding>
1919
<proto-google-common.version>2.22.0</proto-google-common.version>
2020
</properties>

project/Dependencies.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ object Dependencies {
2727
val akkaHttp = "10.7.0"
2828
val akkaHttpBinary = VersionNumber(akkaHttp).numbers match { case Seq(major, minor, _*) => s"$major.$minor" }
2929

30-
val grpc = "1.63.2" // checked synced by VersionSyncCheckPlugin
30+
val grpc = "1.70.0" // checked synced by VersionSyncCheckPlugin
3131

3232
// Even referenced explicitly in the sbt-plugin's sbt-tests
3333
// If changing this, remember to update protoc plugin version to align in

0 commit comments

Comments
 (0)