Don't update beyond scalatest 3.1#1102
Merged
raboof merged 2 commits intoakka:masterfrom Sep 17, 2020
Merged
Conversation
Until akka updates, akka/akka-core#29368 Replaces akka#1094
Contributor
Author
|
Before merging, we should double-check we don't have the problem identified in akka/akka-core#29503 |
Merged
Contributor
Author
|
(checked, failures look OK) |
ignasi35
approved these changes
Sep 17, 2020
Contributor
|
@raboof, akka/akka-core#29503 is still unmerged but I understand it is safe to merge this PR, right? It LGTM and I've approved. Feel free to press the buttons. |
Contributor
Author
Exactly, this PR makes sure we don't update akka-grpc, which is what we want to do until we upgrade on the Akka side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until akka updates, akka/akka-core#29368
Replaces #1094